core: add support for class attributes (issue-102) #425

abdul124 · 2024-06-19T18:15:27+08:00

abdul124 commented

2024-06-19 18:15:27 +08:00

The main changes are as follows:
Class Definition
Created new section for class attributes
Each class retains one copy of immutable attributes

Core
Added support for processing class attributes and their code generation

nac3artiq
Allowed class attributes of classes without __init__ function to be accessed by bypassing the initialization check

The main changes are as follows: **Class Definition** Created new section for class attributes Each class retains one copy of immutable attributes **Core** Added support for processing class attributes and their code generation **nac3artiq** Allowed class attributes of classes without _\_\_init\_\__ function to be accessed by bypassing the initialization check

abdul124 requested review from derppening 2024-06-19 18:18:16 +08:00

derppening requested changes 2024-06-19 18:42:46 +08:00

derppening left a comment

Please run the pre-commit hooks (i.e. cargo clippy and cargo fmt) on each commit so that the apply cargo fmt commit can be dropped.

Please run the pre-commit hooks (i.e. `cargo clippy` and `cargo fmt`) on each commit so that the `apply cargo fmt` commit can be dropped.

nac3core/src/toplevel/composer.rs Outdated

						
				@ -1475,3 +1552,3 @@

				        class_fields_def.drain(..);

				        class_fields_def.extend(new_child_fields);

				        class_attribute_def.drain(..);

derppening commented

2024-06-19 18:41:41 +08:00

class_attribute_def.clear()

You can also change the use above for class_fields_def.

`class_attribute_def.clear()` You can also change the use above for `class_fields_def`.

derppening marked this conversation as resolved

abdul124 force-pushed issue-102 from 5bc76583ef to 45708aadda

2024-06-20 10:05:25 +08:00

Compare

abdul124 commented

2024-06-20 10:08:56 +08:00

Please run the pre-commit hooks (i.e. cargo clippy and cargo fmt) on each commit so that the apply cargo fmt commit can be dropped.

Force pushed to update commit history. Also replaced .drain(..) with .clear() in nac3core/src/toplevel/composer.rs

> Please run the pre-commit hooks (i.e. `cargo clippy` and `cargo fmt`) on each commit so that the `apply cargo fmt` commit can be dropped. Force pushed to update commit history. Also replaced `.drain(..)` with `.clear()` in nac3core/src/toplevel/composer.rs

derppening reviewed 2024-06-20 11:43:15 +08:00

nac3artiq/demo/support_class_attr_issue102.py Outdated

						
				@ -0,0 +4,4 @@

				@nac3

				class XXX:

				    ATTR1: KernelInvariant[int32] = 2

derppening commented

2024-06-20 11:43:15 +08:00

Nit: Does Python use all caps in this way?

abdul124 commented

2024-06-20 13:22:09 +08:00

I was using the example given in #102, but I see your point. I will update the file and while I am at it, refactor nac3core/composer to avoid code duplication