M-Labs/nac3
M-Labs/nac3
8
1
Fork 12
Code Issues 98 Pull Requests 19 Releases Wiki Activity

core: reduce code duplication in codegen/builtin_fns #422

Merged
sb10q merged 7 commits from refactor-builtin-fns into master 2024-06-20 12:48:45 +08:00
Conversation 5 Commits 7 Files Changed 1 +2 -1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c20c9a2c5a - Show all commits

3
nac3core/src/codegen/builtin_fns.rs
View File

@ -1050,7 +1050,8 @@ pub fn call_numpy_maximum<'ctx, G: CodeGenerator + ?Sized>(
/// * `fn_name`: The name of the function, only used when throwing an error with [`unsupported_type`]
/// * `get_ret_elem_type`: A function that takes in the input element [`Type`], and returns the correct return [`Type`].
/// Return a constant [`Type`] here if the return type does not depend on the input type.
/// * `on_elem`: The function to be called when the input argument is not an ndarray.
/// * `on_elem`: The function to be called when the input argument is not an ndarray. Returns [`Option::None`]
/// if the element type & value are faulty and should panic with [`unsupported_type`].
fn helper_call_numpy<'ctx, OnElemFn, RetElemFn, G: CodeGenerator + ?Sized>(
generator: &mut G,
derppening marked this conversation as resolved Outdated
derppening commented 2024-06-19 17:42:12 +08:00
Outdated
Review
Copy Link
  • Move the bounds for G into the where clause.
  • call_numpy makes it seem like you can call any numpy function. Perhaps something like call_numpy_unaryfunc?
- Move the bounds for `G` into the `where` clause. - `call_numpy` makes it seem like you can call any numpy function. Perhaps something like `call_numpy_unaryfunc`?
ctx: &mut CodeGenContext<'ctx, '_>,