M-Labs/nac3
M-Labs/nac3
8
1
Fork 12
Code Issues 98 Pull Requests 19 Releases Wiki Activity

core: reduce code duplication in codegen/builtin_fns #422

Merged
sb10q merged 7 commits from refactor-builtin-fns into master 2024-06-20 12:48:45 +08:00
Conversation 5 Commits 7 Files Changed 1 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 7987dca464 - Show all commits

4
nac3core/src/codegen/builtin_fns.rs
View File

@ -1108,13 +1108,13 @@ where
pub fn call_abs<'ctx, G: CodeGenerator + ?Sized>( pub fn call_abs<'ctx, G: CodeGenerator + ?Sized>(
generator: &mut G, generator: &mut G,
ctx: &mut CodeGenContext<'ctx, '_>, ctx: &mut CodeGenContext<'ctx, '_>,
arg: (Type, BasicValueEnum<'ctx>), n: (Type, BasicValueEnum<'ctx>),
derppening commented 2024-06-20 11:40:01 +08:00
Outdated
Review
Copy Link

Nit: Please keep this parameter as n. I don't think this change is necessary.

Nit: Please keep this parameter as `n`. I don't think this change is necessary.
) -> Result<BasicValueEnum<'ctx>, String> { ) -> Result<BasicValueEnum<'ctx>, String> {
const FN_NAME: &str = "abs"; const FN_NAME: &str = "abs";
derppening marked this conversation as resolved Outdated
derppening commented 2024-06-19 17:53:44 +08:00
Outdated
Review
Copy Link

Is this change from const to let necessary?

Is this change from `const` to `let` necessary?
helper_call_numpy_unary_elementwise( helper_call_numpy_unary_elementwise(
generator, generator,
ctx, ctx,
arg, n,
FN_NAME, FN_NAME,
&|_ctx, elem_ty| elem_ty, &|_ctx, elem_ty| elem_ty,
&|_generator, ctx, val_ty, val| match val { &|_generator, ctx, val_ty, val| match val {