core: move top level def type vars into PrimitiveStore #418

lyken · 2024-06-17T11:53:51+08:00

lyken commented

2024-06-17 11:53:51 +08:00

Top level TypeVars option_type_tvar, ndarray_ndims_tvar, and ndarray_dtype_tvar are now captured by PrimitiveStore. This is to eliminate code that does, say, let ndarray_ndims = *ndarray_params.iter().nth(1).unwrap(), which is incoherent.
Changed unpack_ndarray_var_tys to unpack_ndarray_params after (1.).

1. Top level `TypeVar`s `option_type_tvar`, `ndarray_ndims_tvar`, and `ndarray_dtype_tvar` are now captured by `PrimitiveStore`. This is to eliminate code that does, say, `let ndarray_ndims = *ndarray_params.iter().nth(1).unwrap()`, which is incoherent. 2. Changed `unpack_ndarray_var_tys` to `unpack_ndarray_params` after (1.).

lyken added 1 commit 2024-06-17 11:53:51 +08:00

df1bd467fc core: move top level def type vars into `PrimitiveStore`

lyken requested review from derppening 2024-06-17 12:00:12 +08:00

lyken force-pushed refactor-primstore from df1bd467fc to 31cd6c3792

2024-06-17 12:04:13 +08:00

Compare

derppening commented

2024-06-17 12:52:10 +08:00

Please break the formatting/clippy changes unrelated to the refactoring to a separate commit.

derppening requested changes 2024-06-17 13:03:00 +08:00

nac3core/src/typecheck/type_inferencer/mod.rs Outdated

						
				@ -50,2 +52,4 @@

				    pub exception: Type,

				    pub option: Type,

				    /// The contained type of an `Option`

				    pub option_type_tvar: TypeVar,

derppening commented

2024-06-17 13:02:11 +08:00

I think it might be better if we just have OptionType and NDArrayType, effectively becoming something like

pub struct OptionType {
    pub ty: Type,
    type_tvar: TypeVar,
}

impl OptionType {
    fn subst(type: Type) -> OptionType {}

    fn unpack_type(option: Type) -> Type {}
}

I think it might be better if we just have `OptionType` and `NDArrayType`, effectively becoming something like ```rs pub struct OptionType { pub ty: Type, type_tvar: TypeVar, } impl OptionType { fn subst(type: Type) -> OptionType {} fn unpack_type(option: Type) -> Type {} } ```