M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 98 Pull Requests 20 Releases Wiki Activity

WIP: Run standalone demos as part of Cargo Test #356

Draft
derppening wants to merge 2 commits from enhance/cargo-test-standalone-demos into master
pull from: enhance/cargo-test-standalone-demos
merge into: M-Labs:master
Conversation 3 Commits 2 Files Changed 3 +1 -3
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit affa19e88d - Show all commits

4
flake.nix
View File

@ -29,12 +29,10 @@
checkInputs = [ (pkgs.python3.withPackages(ps: [ ps.numpy ps.scipy ])) ]; checkInputs = [ (pkgs.python3.withPackages(ps: [ ps.numpy ps.scipy ])) ];
checkPhase = checkPhase =
'' ''
echo "Checking nac3standalone demos..." echo "Running Cargo tests..."
pushd nac3standalone/demo pushd nac3standalone/demo
patchShebangs . patchShebangs .
sb10q commented 2023-12-12 15:38:25 +08:00
Review
Copy Link

Just remove pushd/popd and do patchShebangs nac3standalone/demo?

But I thought the plan was to remove shell scripts anyway. Then there are no shebangs to patch?

Just remove pushd/popd and do ``patchShebangs nac3standalone/demo``? But I thought the plan was to remove shell scripts anyway. Then there are no shebangs to patch?
derppening commented 2023-12-12 15:39:29 +08:00
Review
Copy Link

Yeah it's not ready yet, that push was just a rebase.

Marked WIP now for clarity.

Yeah it's not ready yet, that push was just a rebase. Marked WIP now for clarity.
./check_demos.sh
popd popd
echo "Running Cargo tests..."
cargoCheckHook cargoCheckHook
''; '';
installPhase = installPhase =