ld: Fix remapping of FDEs with multiple CFIs #343

derppening · 2023-10-20T18:16:57+08:00

derppening commented

2023-10-20 18:16:57 +08:00

The previous implementation assumes that each .eh_frame section will only contain one CFI (and hence one CIE) record, but this is shown not to hold when compiling with no optimizations.

This PR fixes that by refactoring the parsing and handling of records in the .eh_frame section, such that multiple CFIs within .eh_frame is properly handled. This PR also refactors the reading of CFI/CIE/FDE into a hierarchical manner.

The previous implementation assumes that each `.eh_frame` section will only contain one CFI (and hence one CIE) record, but this is shown not to hold when compiling with no optimizations. This PR fixes that by refactoring the parsing and handling of records in the `.eh_frame` section, such that multiple CFIs within `.eh_frame` is properly handled. This PR also refactors the reading of CFI/CIE/FDE into a hierarchical manner.

derppening self-assigned this 2023-10-20 18:16:57 +08:00

derppening added 3 commits 2023-10-20 18:16:59 +08:00

e1487ed335 cargo: Update dependencies

aa92778363 ld: Fix remapping of FDEs with multiple CFIs

e49b760e34 ld: Support multiple CFIs with different encoding in .eh_frame

We now parse each CFI to read its encoding as opposed to assuming that
all CFIs within the same EH_Frame uses the same encoding. FDEs are now
iterated in a per-CFI manner.

derppening requested review from sb10q 2023-10-20 18:17:04 +08:00

sb10q merged commit e49b760e34 into master

2023-10-20 18:18:40 +08:00

Sign in to join this conversation.

No reviewers