M-Labs
/
nac3
8
0
Fork 5
Code Issues 87 Pull Requests 3 Releases Wiki Activity

Minor improvements to multithreaded compilation in Standalone #341

Merged
sb10q merged 4 commits from fix/threading-support into master 2023-10-16 15:55:56 +08:00
Conversation 4 Commits 4 Files Changed 2
derppening commented 2023-10-13 15:04:42 +08:00
Collaborator
  • Require the use of -T to specify threading
  • Treat -T0 as using all available threads
  • Fix run_demo.sh script to clean all previous build output and link all bitcode modules from different threads
- Require the use of `-T` to specify threading - Treat `-T0` as using all available threads - Fix `run_demo.sh` script to clean all previous build output and link all bitcode modules from different threads
derppening added 4 commits 2023-10-13 15:04:45 +08:00
8c7cf4f8f3 standalone: Fix run_demo script 
- Link main and module*.bc together if using multiple threads
- Fix temporary files not being deleted
derppening requested review from sb10q 2023-10-13 15:04:50 +08:00
derppening added a new dependency 2023-10-13 15:05:07 +08:00
#298 "with parallel" breakage
derppening removed a dependency 2023-10-13 15:05:10 +08:00
#298 "with parallel" breakage
derppening self-assigned this 2023-10-13 15:05:25 +08:00
derppening added a new dependency 2023-10-13 15:05:35 +08:00
#340 Fix thread safety with LLVM library
derppening added 2 commits 2023-10-16 12:21:41 +08:00
d7dfab863a standalone: Fix run_demo script 
- Link main and module*.bc together if using multiple threads
- Fix temporary files not being deleted
derppening commented 2023-10-16 12:22:09 +08:00
Poster
Collaborator

v2: Use llvm-link even if there is only one input file

v2: Use `llvm-link` even if there is only one input file
derppening added 2 commits 2023-10-16 13:44:40 +08:00
d806ad841c standalone: Fix run_demo script 
- Link main and module*.bc together if using multiple threads
- Fix temporary files not being deleted
derppening commented 2023-10-16 13:45:54 +08:00
Poster
Collaborator

v3: Use nullglob to collect all module*.bc file (even if they do not exist)

v3: Use `nullglob` to collect all `module*.bc` file (even if they do not exist)
derppening added 2 commits 2023-10-16 14:18:54 +08:00
a49f927526 standalone: Fix run_demo script 
- Link main and module*.bc together if using multiple threads
- Fix temporary files not being deleted
derppening commented 2023-10-16 14:19:55 +08:00
Poster
Collaborator

v4: Squashed redundant commits

v4: Squashed redundant commits
sb10q reviewed 2023-10-16 15:48:42 +08:00
nac3standalone/demo/run_demo.sh Outdated
@ -52,2 +49,4 @@
clang -c -std=gnu11 -Wall -Wextra -O3 -emit-llvm -o demo.bc demo.c
shopt -s nullglob
llvm-link -o module.bc module*.bc main.bc
sb10q commented 2023-10-16 15:48:42 +08:00
Owner

Isn't module*.bc also matching module.bc? I know you are deleting it above but it looks confusing and a potential source of bugs. Better rename it to something else and clear e.g nac3output.bc ?

Isn't module*.bc also matching module.bc? I know you are deleting it above but it looks confusing and a potential source of bugs. Better rename it to something else and clear e.g nac3output.bc ?
derppening commented 2023-10-16 15:54:37 +08:00
Poster
Collaborator

Addressed in v5.

Addressed in v5.
derppening added 2 commits 2023-10-16 15:53:56 +08:00
a50c690428 standalone: Fix run_demo script 
- Link main and module*.bc together if using multiple threads
- Fix temporary files not being deleted
derppening commented 2023-10-16 15:54:41 +08:00
Poster
Collaborator

v5: Renamed output bitcode to nac3out.bc.

v5: Renamed output bitcode to `nac3out.bc`.
sb10q merged commit 950f431483 into master 2023-10-16 15:55:56 +08:00
sb10q deleted branch fix/threading-support 2023-10-16 15:55:58 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
sb10q
Labels
Clear labels   
UROP0622
   
future-extension
   
high-priority
   
low-priority
No Label
UROP0622
future-extension
high-priority
low-priority
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
derppening
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#340 Fix thread safety with LLVM library
M-Labs/nac3
Reference: M-Labs/nac3#341
There is no content yet.
Delete Branch "fix/threading-support"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?