M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 8
Code Issues 100 Pull Requests 20 Releases Wiki Activity

Meta changes from Issue 233 #330

Closed
derppening wants to merge 2 commits from meta-changes-from-issue-233 into master
pull from: meta-changes-from-issue-233
merge into: M-Labs:master
Conversation 3 Commits 2 Files Changed 4 +62 -22
derppening commented 2023-10-05 12:09:17 +08:00
Collaborator
Copy Link
  • Implement comparison operators for unsigned integral types
  • Add output_bool in demo library
  • Import IntPredicate
- Implement comparison operators for unsigned integral types - Add `output_bool` in demo library - Import `IntPredicate`
derppening self-assigned this 2023-10-05 12:09:17 +08:00
derppening added 2 commits 2023-10-05 12:09:18 +08:00
sb10q reviewed 2023-10-05 12:14:18 +08:00
nac3standalone/demo/demo.c
@ -32,3 +37,3 @@
}
void output_asciiart(const int32_t x) {
const char* chars = " .,-:;i+hHM$*#@ ";
static const char *chars = " .,-:;i+hHM$*#@ ";
sb10q commented 2023-10-05 12:14:18 +08:00
Owner
Copy Link

Doesn't belong in this PR/commit

Doesn't belong in this PR/commit
sb10q commented 2023-10-05 12:15:07 +08:00
Owner
Copy Link

What do any of these have to do with #233?

What do any of these have to do with #233?
derppening commented 2023-10-05 12:15:57 +08:00
Author
Collaborator
Copy Link

What do any of these have to do with #233?

They are just "meta changes", changes that I made while trying to fix #233. Is there a better way to name these cleanup PRs?

> What do any of these have to do with #233? They are just "meta changes", changes that I made while trying to fix #233. Is there a better way to name these cleanup PRs?
sb10q commented 2023-10-05 12:16:59 +08:00
Owner
Copy Link

Simple. Just open two PRs, one with title "Add output_bool in demo" and another one with title "support comparison of unsigned integers".

Simple. Just open two PRs, one with title "Add output_bool in demo" and another one with title "support comparison of unsigned integers".
derppening closed this pull request 2023-10-05 12:18:56 +08:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
derppening
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#330
No description provided.
Delete Branch "meta-changes-from-issue-233"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?