nac3artiq: update InnerResolver's "pyid_to_type" table if class contain constructor function #309

z78078 · 2022-07-22T12:44:59+08:00

z78078 commented

2022-07-22 12:44:59 +08:00

The code below failed because the InnerResolver's 'pyid_to_type' table didn't store the type information for the classes that don't have their own constructor.

@nac3
class A
    @kernel
    def __init__(self):
        pass


@nac3
class B(A):
    pass


@nac3
class C(B):
    pass


@nac3
class Demo:
    core: KernelInvariant[Core]

    def __init__(self):
        self.core = Core()

    @kernel
    def run(self):
    	c = C()

>>>
nac3artiq.CompileError: compilation failed
----------
type error at identifier `C` (<class 'type'> is not registered with NAC3 (@nac3 decorator missing?))

In the register step, TopLevelComposer::reigster_top_level won't return the constructor's type of the class that doesn't have a constructor and therefore the 'pyid_to_type' will not be abled to store the type information for the class (the ty is None here).

Although class without its own constructor function will inherit an init function from its base class in the analyze_top_level_class_fields_methods step, the 'pyid_to_type' table never got updated.

This change update the 'pyid_to_type' table in the InnerResolver's get_obj_type function when an init method exists in the methods list of a class definition.

The code below failed because the InnerResolver's 'pyid_to_type' table didn't store the type information for the classes that don't have their own constructor. ``` @nac3 class A @kernel def __init__(self): pass @nac3 class B(A): pass @nac3 class C(B): pass @nac3 class Demo: core: KernelInvariant[Core] def __init__(self): self.core = Core() @kernel def run(self): c = C() >>> nac3artiq.CompileError: compilation failed ---------- type error at identifier `C` (<class 'type'> is not registered with NAC3 (@nac3 decorator missing?)) ``` In the register step, TopLevelComposer::reigster_top_level won't return the constructor's type of the class that doesn't have a constructor and therefore the 'pyid_to_type' will not be abled to store the type information for the class (the ty is None [here](https://git.m-labs.hk/M-Labs/nac3/src/branch/master/nac3artiq/src/lib.rs#L416-L418)). Although class without its own constructor function will inherit an __init__ function from its base class in the analyze_top_level_class_fields_methods step, the 'pyid_to_type' table never got updated. This change update the 'pyid_to_type' table in the InnerResolver's get_obj_type function when an __init__ method exists in the methods list of a class definition.

z78078 added 3 commits 2022-07-22 12:44:59 +08:00

nac3artiq: insert the constructor type to HashMap 'pyid_to_type' if class possess an __init__ method af5672020e

nac3artiq: insert the constructor type to table 'pyid_to_type' if class possess an __init__ method 067da378c6

Merge branch 'issue-139-2' of git.m-labs.hk:M-Labs/nac3 into issue-139-2 815176c8c7

z78078 added 2 commits 2022-07-22 12:47:55 +08:00

Merge branch 'issue-139-2' of git.m-labs.hk:M-Labs/nac3 into issue-139-2 785c6bcbb0

Merge branch 'issue-139-2' of git.m-labs.hk:M-Labs/nac3 into issue-139-2 5d5ec52170

z78078 added 2 commits 2022-07-22 12:50:15 +08:00

Merge branch 'issue-139-2' of git.m-labs.hk:M-Labs/nac3 into issue-139-2 3585ab9d06

Merge branch 'issue-139-2' of git.m-labs.hk:M-Labs/nac3 into issue-139-2 0b99241576

sb10q merged commit b514f91441 into master

2022-07-28 19:18:36 +08:00