M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 97 Pull Requests 20 Releases Wiki Activity

221-fix-classes-without-__init__-should-be-valid #304

Merged
sb10q merged 8 commits from 221-fix-classes-without-__init__-should-be-valid into master 2022-07-07 10:36:25 +08:00
Conversation 1 Commits 8 Files Changed 4 +26 -9
z78078 commented 2022-07-06 16:20:24 +08:00
Contributor
Copy Link
No description provided.
z78078 added 6 commits 2022-07-06 16:20:25 +08:00
z78078 added 1 commit 2022-07-06 16:23:34 +08:00
sb10q reviewed 2022-07-06 20:56:43 +08:00
nac3core/src/toplevel/test.rs
@ -123,0 +132,4 @@
let mut composer: TopLevelComposer = Default::default();
let ast = parse_program(source, Default::default()).unwrap();
let ast = ast[0].clone();
composer.register_top_level(ast, None, "".into(), false).unwrap();
sb10q commented 2022-07-06 20:56:43 +08:00
Owner
Copy Link

Shouldn't it be true?

Shouldn't it be ``true``?
sb10q commented 2022-07-06 21:14:48 +08:00
Owner
Copy Link

From the issue:
"We need to do the right thing if the user mistakenly decorates __init__ with @rpc."
This is not addressed yet, correct?

The commit messages (and the PR title) are not very good, but I'll probably do a squash merge anyway.

From the issue: "We need to do the right thing if the user mistakenly decorates ``__init__`` with @rpc." This is not addressed yet, correct? The commit messages (and the PR title) are not very good, but I'll probably do a squash merge anyway.
z78078 added 1 commit 2022-07-07 10:07:51 +08:00
sb10q merged commit ebd25af38b into master 2022-07-07 10:36:25 +08:00
sb10q deleted branch 221-fix-classes-without-__init__-should-be-valid 2022-07-07 10:36:27 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#304
No description provided.
Delete Branch "221-fix-classes-without-__init__-should-be-valid"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?