221-fix-classes-without-__init__-should-be-valid #304

z78078 · 2022-07-06T16:20:24+08:00

z78078 commented

2022-07-06 16:20:24 +08:00

There is no content yet.

z78078 added 6 commits 2022-07-06 16:20:25 +08:00

84011743f9 add argument allow_no_constructor when calling the function register_top_level

7f816bb01c modified the tests upon the changes

8c26f186b5 add parameter allow_no_constructor to the function register_top_level

8ee10802c9 update/add the arguments on the register_top_level

29525e222a add parameter to the function register_top_level

012af93cfa Merge branch '221-fix-classes-without-__init__-should-be-valid' of git.m-labs.hk:M-Labs/nac3 into 221-fix-classes-without-__init__-should-be-valid

z78078 added 1 commit 2022-07-06 16:23:34 +08:00

2be5d96635 remove space

sb10q reviewed 2022-07-06 20:56:43 +08:00

nac3core/src/toplevel/test.rs

													
				@ -123,0 +132,4 @@

				    let mut composer: TopLevelComposer = Default::default();

				    let ast = parse_program(source, Default::default()).unwrap();

				    let ast = ast[0].clone();

				    composer.register_top_level(ast, None, "".into(), false).unwrap();

sb10q commented

2022-07-06 20:56:43 +08:00

Shouldn't it be true?

Shouldn't it be ``true``?

sb10q commented

2022-07-06 21:14:48 +08:00

From the issue:
"We need to do the right thing if the user mistakenly decorates __init__ with @rpc."
This is not addressed yet, correct?

The commit messages (and the PR title) are not very good, but I'll probably do a squash merge anyway.

From the issue: "We need to do the right thing if the user mistakenly decorates ``__init__`` with @rpc." This is not addressed yet, correct? The commit messages (and the PR title) are not very good, but I'll probably do a squash merge anyway.

z78078 added 1 commit 2022-07-07 10:07:51 +08:00

f9b7f28870 correct parameter of the function call

sb10q merged commit ebd25af38b into master

2022-07-07 10:36:25 +08:00

sb10q deleted branch 221-fix-classes-without-__init__-should-be-valid

2022-07-07 10:36:27 +08:00

sb10q referenced this issue from a commit

2022-07-07 10:36:27 +08:00

nac3standalone: allow classes without explicit init (#221)

Sign in to join this conversation.

No reviewers