M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 97 Pull Requests 20 Releases Wiki Activity

275-fix-random-sigsegv #302

Merged
sb10q merged 9 commits from 275-fix-random-sigsegv into master 2022-07-04 18:06:36 +08:00
Conversation 0 Commits 9 Files Changed 3 +18 -3
z78078 commented 2022-07-04 16:18:02 +08:00
Contributor
Copy Link

This PR is a workaround for the #275

  • Create Global Lock for the critical section
  • define a critical section for the error-prone lines

Variable holder "_data" is required in the line let data = PASSESINITLOCK.lock(); even it is not used.

This PR is a workaround for the https://git.m-labs.hk/M-Labs/nac3/issues/275 * Create Global Lock for the critical section * define a critical section for the error-prone lines Variable holder *"_data"* is required in the line *let data = PASSESINITLOCK.lock();* even it is not used.
z78078 added 4 commits 2022-07-04 16:18:03 +08:00
z78078 added 1 commit 2022-07-04 16:26:00 +08:00
z78078 added 1 commit 2022-07-04 16:33:07 +08:00
z78078 added 1 commit 2022-07-04 16:35:21 +08:00
sb10q reviewed 2022-07-04 16:48:31 +08:00
nac3core/src/lib.rs Outdated
@ -2,2 +2,4 @@
#![allow(dead_code)]
#[macro_use]
extern crate lazy_static;
sb10q commented 2022-07-04 16:48:31 +08:00
Owner
Copy Link

Can't you just do use lazy_static in codegen/mod.rs?

IIRC recent Rust can treat macros like other imports.

Can't you just do ``use lazy_static`` in ``codegen/mod.rs``? IIRC recent Rust can treat macros like other imports.
z78078 added 1 commit 2022-07-04 18:02:12 +08:00
z78078 added 1 commit 2022-07-04 18:05:43 +08:00
sb10q merged commit 96b3a3bf5c into master 2022-07-04 18:06:36 +08:00
sb10q deleted branch 275-fix-random-sigsegv 2022-07-04 18:06:36 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#302
No description provided.
Delete Branch "275-fix-random-sigsegv"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?