M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 100 Pull Requests 20 Releases Wiki Activity

Add bound check for list and range (#185) #255

Merged
sb10q merged 1 commits from bound_check into master 2024-08-17 17:37:19 +08:00
Conversation 1 Commits 1 Files Changed 1 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 86ce513cb5 - Show all commits

2
nac3standalone/demo/src/lists.py
View File

@ -229,7 +229,7 @@ def list_slice_assignment():
bl5[3:-5] = [] bl5[3:-5] = []
output_int32_list([int32(b) for b in bl5]) output_int32_list([int32(b) for b in bl5])
bl6 = bl[:] bl6 = bl[:]
bl6[3:-5] = [True, False, False] bl6[3:-5] = [True, False]
pca006132 marked this conversation as resolved
pca006132 commented 2022-04-05 19:14:36 +08:00
Review
Copy Link

what is this?

what is this?
ychenfo commented 2022-04-06 00:05:21 +08:00
Review
Copy Link

This is the 'fix broken test' commit. This test should not pass because the length of bl6 is 10, so bl[3:-5] is bl[3,5], which has length 2, so this test is actually extending the list, which is not supported.

Previously this test happened to accidentally pass because we do not have the check on the list slice assignment yet, and the value of the assignment accidentally make the test pass. In fact, just by changing the bl6[3:-5] = [True, False, False] to bl6[3:-5] = [True, False, True] or something else, this test will fail before this PR.

This is the 'fix broken test' commit. This test should not pass because the length of `bl6` is 10, so `bl[3:-5]` is `bl[3,5]`, which has length 2, so this test is actually extending the list, which is not supported. Previously this test happened to accidentally pass because we do not have the check on the list slice assignment yet, and the value of the assignment accidentally make the test pass. In fact, just by changing the `bl6[3:-5] = [True, False, False]` to `bl6[3:-5] = [True, False, True]` or something else, this test will fail before this PR.
output_int32_list([int32(b) for b in bl6]) output_int32_list([int32(b) for b in bl6])
bl7 = bl[:] bl7 = bl[:]
bl7[:-2] = [False] bl7[:-2] = [False]