nac3core: do not get llvm value too eagerly for kernel invariant #253
No reviewers
Labels
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: M-Labs/nac3#253
Loading…
Reference in New Issue
No description provided.
Delete Branch "kernel_invariant_fix"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Notice this when looking into optimizing
unwrap
forKernelInvariant
fields ofOption
type. I previously modifed the code such that it is getting llvm value too eagerly, disabling the KernelInvariant optimization.previous output
output after this PR
nac3core not na3core
8d66426139
to2edeb31d21
Thanks! Force pushed to fix the typo.
na3core: do not get llvm value too eagerly for kernel invariantto nac3core: do not get llvm value too eagerly for kernel invariantMight be good to have tests for this kind of thing that look at the IR.
Yes, we can see if there is a
call void @print_int32(i32 123)
. We should not match the entire IR as it is too brittle.