M-Labs/nac3
M-Labs/nac3
8
1
Fork 13
Code Issues 95 Pull Requests 4 Releases Wiki Activity

nac3artiq: implement attribute writeback #239

Merged
sb10q merged 1 commits from attribute-writeback into master 2022-03-26 20:13:58 +08:00
Conversation 2 Commits 1 Files Changed 6 +164 -39
pca006132 commented 2022-03-25 23:44:03 +08:00
Contributor
Copy Link

We will only writeback attributes that are supported by the current RPC implementation: primitives, tuple and lists of lists... of primitives.

The changes are also pushed to artiq: 457f3c72ce

Closes #212

We will only writeback attributes that are supported by the current RPC implementation: primitives, tuple and lists of lists... of primitives. The changes are also pushed to artiq: https://github.com/m-labs/artiq/commit/457f3c72ce2edc33c1ea4dd8dc263a291360429b Closes #212
pca006132 commented 2022-03-25 23:47:24 +08:00
Author
Contributor
Copy Link

Instead of sending multiple requests, I chose to construct a header parameter that tells the host all attributes that has to be updated. Hopefully this can be more performant when we have objects with a lot of attributes.

This will send all global variable data back to the host, instead of just attributes of the experiment.

Instead of sending multiple requests, I chose to construct a header parameter that tells the host all attributes that has to be updated. Hopefully this can be more performant when we have objects with a lot of attributes. This will send all global variable data back to the host, instead of just attributes of the experiment.
pca006132 force-pushed attribute-writeback from a1bb809b7f to fef2f996fa 2022-03-26 19:15:33 +08:00 Compare
pca006132 force-pushed attribute-writeback from fef2f996fa to c955927eda 2022-03-26 19:22:09 +08:00 Compare
pca006132 commented 2022-03-26 19:23:15 +08:00
Author
Contributor
Copy Link

Done, no need for JSON now

Done, no need for JSON now
sb10q merged commit bf067e2481 into master 2022-03-26 20:13:58 +08:00
sb10q deleted branch attribute-writeback 2022-03-26 20:13:58 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#239
No description provided.
Delete Branch "attribute-writeback"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?