min, max, abs support (#201, #206) #216

ychenfo · 2022-03-08T23:33:41+08:00

ychenfo commented

2022-03-08 23:33:41 +08:00

Add support for min, max, abs functions.

For abs, previously I thought it would be helpful to make it return unsigned integers, but after checking some more materials, it seems that it is a convention to return signed integers, and most languages like c++/c/java/rust and numpy also returns signed integers. And making abs to return unsigned integers would require having different variant names like abs32, abs64 and absfloat under our type system, so I currently implemented a single abs whose return type is the same as its input type.

Add support for `min`, `max`, `abs` functions. For `abs`, previously I thought it would be helpful to make it return unsigned integers, but after checking some more materials, it seems that it is a convention to return signed integers, and most languages like c++/c/java/rust and numpy also returns signed integers. And making `abs` to return unsigned integers would require having different variant names like `abs32`, `abs64` and `absfloat` under our type system, so I currently implemented a single `abs` whose return type is the same as its input type.

ychenfo added 6 commits 2022-03-08 23:33:41 +08:00

adb5c69e67 nac3core: min builtin function

e9a17cf8f8 nac3standalone: add test for min function

8241a29908 nac3core: max builtin function

1cc276cb43 nac3standalone: add test for max function

5006028e2d nac3core: abs builtin function

60b3807ab3 nac3standalone: add test for abs function

sb10q commented

2022-03-09 09:01:40 +08:00

I don't think the boolean case is very useful or meaningful, but it's not a lot of code and cpython does support it...

sb10q merged commit 60b3807ab3 into master

2022-03-09 09:04:24 +08:00