Add file name to error messages (#70) #155

Merged
sb10q merged 1 commits from ast_filename_location into master 2024-08-17 17:37:19 +08:00
Collaborator

Add file name to error messages by adding file name to the AST.

Use line .. column .. format to the location inside the file.

Add file name to error messages by adding file name to the AST. Use `line .. column ..` format to the location inside the file.
ychenfo force-pushed ast_filename_location from 178a904c18 to 9b3b47ce50 2021-12-28 01:40:52 +08:00 Compare
sb10q reviewed 2021-12-28 10:45:45 +08:00
@ -65,3 +65,3 @@
);
let parser_result = parser::parse_program(&program).unwrap();
let parser_result = parser::parse_program(&program, format!("{}.py", demo_name).into()).unwrap();
Owner

nitpicking but it's using demo_name + ".py" above

nitpicking but it's using ``demo_name + ".py"`` above
sb10q reviewed 2021-12-28 10:46:57 +08:00
@ -101,3 +101,3 @@
exceptions::PyIOError::new_err(format!("failed to read input file: {}", e))
})?;
let parser_result = parser::parse_program(&source)
let parser_result = parser::parse_program(&source, source_file.into())
Owner

No more absolute path?

No more absolute path?
Owner

Ah, __file__ is already absolute. OK.

Ah, ``__file__`` is already absolute. OK.
sb10q merged commit 9b3b47ce50 into master 2021-12-28 10:48:18 +08:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#155
No description provided.