Polymorphism Fixes #104

ychenfo · 2021-11-21T06:22:35+08:00

ychenfo commented

2021-11-21 06:22:35 +08:00

Handle polymorphic class methods containing typevars not in class declaration correctly
Fix handling on rigid typevars
Some minor error message improvements.

1. Handle polymorphic class methods containing typevars not in class declaration correctly 2. Fix handling on rigid typevars 3. Some minor error message improvements.

ychenfo added 6 commits 2021-11-21 06:22:35 +08:00

c2706fa720 nac3core: fix polymorphic class method partial instantiation

a9635f0979 nac3core: top level use codegen official get_subst_key

a50df6560e nac3core: fix handling on rigid typevar

d336200bf4 nac3core: fix broken tests due to the fix of rigid typevar handling

aae9925014 nac3standalone: report when entry point run function cannot be found

01b51b62ee nac3core: composer better error msg in for uninit field

sb10q requested review from pca006132 2021-11-21 11:50:24 +08:00

pca006132 approved these changes 2021-11-21 20:04:35 +08:00

sb10q reviewed 2021-11-22 13:03:21 +08:00

nac3standalone/src/main.rs Outdated

						
				@ -104,0 +103,4 @@

				        let mut instance =

				            defs[resolver

				                .get_identifier_def("run".into())

				                .unwrap_or_else(|| panic!("cannot find `run() -> int32 entry point`")).0

sb10q commented

2021-11-22 13:03:21 +08:00

I don't think the -> int32 part is relevant. And remove the `

I don't think the ``-> int32`` part is relevant. And remove the `` ` ``

sb10q reviewed 2021-11-22 13:03:49 +08:00

nac3core/src/codegen/concrete_type.rs Outdated

						
				@ -151,1 +150,3 @@

				                            (*name, (self.from_unifier_type(unifier, primitives, ty.0, cache), ty.1))

				                        .filter_map(|(name, ty)| {

				                            // filter out functions as they can have type vars and

				                            // will not affect codegen

sb10q commented

2021-11-22 13:03:49 +08:00

What does this comment mean? Did you mean "cannot have type vars..."?

ychenfo commented

2021-11-22 14:42:49 +08:00

Yes, here since we are concretizing types, all class fields should not have type vars. But due to partial instantiation of class methods, there might still be some methods whose signature contains type vars. So I filter out all the functions here since class methods here does not affect codegen.

I will put clearer comments here in a later commit.

Yes, here since we are concretizing types, all class fields should not have type vars. But due to partial instantiation of class methods, there might still be some methods whose signature contains type vars. So I filter out all the functions here since class methods here does not affect codegen. I will put clearer comments here in a later commit.

sb10q reviewed 2021-11-22 13:04:23 +08:00

nac3core/src/typecheck/typedef/mod.rs Outdated

						
				@ -735,3 +728,1 @@

				            } else {

				                instantiated = true;

				                break;

				                // need to do this for partial instantiated function

sb10q commented

2021-11-22 13:04:23 +08:00

to do what?

ychenfo commented

2021-11-22 14:46:01 +08:00

To change the way to check whether a function is instantiated (e.g., as long as there exits one uninstantiated type var, the function is not instantiated)

Thanks for pointing it out, I will also put clearer comments here in a later commit.

To change the way to check whether a function is instantiated (e.g., as long as there exits one uninstantiated type var, the function is not instantiated) Thanks for pointing it out, I will also put clearer comments here in a later commit.

ychenfo added 3 commits 2021-11-22 15:06:37 +08:00

c6f75c8bde nac3standalone: fix error message when no entry point is found

664e02cec4 nac3core: fix clippy warning

49476d06e1 nac3core: clearer comments

sb10q merged commit 49476d06e1 into master

2021-11-22 17:23:12 +08:00

sb10q commented

2021-11-22 17:23:21 +08:00

Thanks

Sign in to join this conversation.

No reviewers