expression type check #1

pca006132 · 2020-12-30T12:47:16+08:00

pca006132 commented

2020-12-30 12:47:16 +08:00

Implemented expression type check and limited type inference for type variables.

The error messages are just for debugging, would be modified later to include location and more precise error messages.

The implementation is equivalent to the python implementation in https://git.m-labs.hk/pca006132/nac3-spec/src/branch/master/toy-impl
Tweaks have been made to account for the differences between the AST of python and rustpython parser, lifetime and performance limitation, and fixed some bugs in inference.

Self parameter is not included in method argument list.
Type enum uses ID for referencing to the type definition, in order to prevent cyclic dependency.
Rc is used extensively to deal with lifetime issues, and minimize cloning.

Primitives cannot be made into static const, as Rc cannot be shared across threads safely, and Arc would probably add too much overhead which is not really needed.
One optimization might be to include the primitives in the context object as fields, to reduce overhead and memory usage of initializing many different Rcs containing the same object. Would be implemented later.

Expression and type inference are tested extensively.

Implemented expression type check and limited type inference for type variables. The error messages are just for debugging, would be modified later to include location and more precise error messages. The implementation is equivalent to the python implementation in https://git.m-labs.hk/pca006132/nac3-spec/src/branch/master/toy-impl Tweaks have been made to account for the differences between the AST of python and rustpython parser, lifetime and performance limitation, and fixed some bugs in inference. * Self parameter is not included in method argument list. * Type enum uses ID for referencing to the type definition, in order to prevent cyclic dependency. * Rc is used extensively to deal with lifetime issues, and minimize cloning. Primitives cannot be made into static const, as Rc cannot be shared across threads safely, and Arc would probably add too much overhead which is not really needed. One optimization might be to include the primitives in the context object as fields, to reduce overhead and memory usage of initializing many different `Rc`s containing the same object. Would be implemented later. Expression and type inference are tested extensively.

pca006132 force-pushed expression-type from 98d34e74ef to 50ffded020

2020-12-30 15:35:29 +08:00

Compare

pca006132 added 1 commit 2020-12-30 15:35:58 +08:00

b87a88b68c added todo

pca006132 added 1 commit 2020-12-30 16:03:16 +08:00

ae953b9728 updated todo

pca006132 added 1 commit 2020-12-30 16:29:29 +08:00

aaebe4e574 updated todo

sb10q commented

2020-12-31 11:23:15 +08:00

Looks great!