M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 99 Pull Requests 21 Releases Wiki Activity

improve type annotation error message #87

New Issue
Closed
opened 2021-11-10 16:46:56 +08:00 by sb10q · 3 comments
sb10q commented 2021-11-10 16:46:56 +08:00
Owner
Copy Link

Currently any problem with a type annotation results in

thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "name cannot be parsed as a type annotation"', nac3artiq/src/lib.rs:378:44

There should at least be an indication about where the problematic type annotation is.

Currently any problem with a type annotation results in ``` thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "name cannot be parsed as a type annotation"', nac3artiq/src/lib.rs:378:44 ``` There should at least be an indication about where the problematic type annotation is.
sb10q referenced this issue from a commit 2021-12-22 08:52:20 +08:00
improve error messages
sb10q closed this issue 2021-12-22 08:54:01 +08:00
sb10q commented 2021-12-22 17:56:00 +08:00
Author
Owner
Copy Link
class A:
    c: bogustype

Prints the confusing message:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "name cannot be parsed as a type annotation at line 13 column 8"', nac3standalone/src/main.rs:224:35

The parsing is actually fine - the error is the identifier does not exist.
Can we do better and print more fine-grained errors?

```python class A: c: bogustype ``` Prints the confusing message: ``` thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "name cannot be parsed as a type annotation at line 13 column 8"', nac3standalone/src/main.rs:224:35 ``` The parsing is actually fine - the error is the identifier does not exist. Can we do better and print more fine-grained errors?
sb10q reopened this issue 2021-12-22 17:56:01 +08:00
ychenfo referenced this issue from a commit 2021-12-27 16:57:43 +08:00
improve error messages
sb10q commented 2021-12-28 10:50:48 +08:00
Author
Owner
Copy Link

Would be better if it gave the nature of the error instead of "not a valid type annotation" for anything that goes wrong...

Would be better if it gave the nature of the error instead of "not a valid type annotation" for anything that goes wrong...
sb10q closed this issue 2022-02-22 16:03:10 +08:00
sb10q commented 2022-02-22 16:29:07 +08:00
Author
Owner
Copy Link
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "`bogustype` is not a valid type annotation (at src/classes.py: line 6 column 8)"', nac3standalone/src/main.rs:223:35
``` thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "`bogustype` is not a valid type annotation (at src/classes.py: line 6 column 8)"', nac3standalone/src/main.rs:223:35 ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
ndstrides-neo-next
misc/impl-tracert
ndstrides-14-end
ndstrides-13-tests
ndstrides-12-builtins
ndstrides-11-matmul
ndstrides-10-ops
ndstrides-9-subassign
ndstrides-8-transpose
ndstrides-7-broadcasting
ndstrides-6-reshape
ndstrides-5-miscfuncs
ndstrides-4-nparray
ndstrides-3-indexing
ndstrides-2-basic
ndstrides-1-model
ndstrides
refactor_composer
misc/update-pyo3
misc/mold
ndstrides-1-model-lifetime
ndstrides-enhance-irrt
ndstrides-intro
issue-313
refactor-primstore
numpy-anyall
enhance/cargo-test-standalone-demos
issue-136
rpc-obj-as-param
iterators
escape-analysis
refactor_anto
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#87
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?