deriving from EnvExperiment causes compilation failure #80

New Issue

sb10q · 2021-11-10T12:28:50+08:00

sb10q commented

2021-11-10 12:28:50 +08:00

Experiments in ARTIQ derive from EnvExperiment, and this is currently incompatible with NAC3. The compiler fails with this rather obscure error message:

thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "name cannot be parsed as a type annotation"', nac3artiq/src/lib.rs:378:44

Should we just ignore ancestor classes that are not decorated with @nac3?

Experiments in ARTIQ derive from ``EnvExperiment``, and this is currently incompatible with NAC3. The compiler fails with this rather obscure error message: ``` thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "name cannot be parsed as a type annotation"', nac3artiq/src/lib.rs:378:44 ``` Should we just ignore ancestor classes that are not decorated with ``@nac3``?

sb10q added the

high-priority

label 2021-11-10 12:28:50 +08:00

sb10q commented

2021-11-10 12:31:06 +08:00

and decorating EnvExperiment and its ancestors with @nac3 fails with:

thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "a class def can only have at most one base class declaration and one generic declaration"', nac3artiq/src/lib.rs:378:44

Removing the Experiment ancestor works around the problem.

and decorating ``EnvExperiment`` and its ancestors with ``@nac3`` fails with: ``` thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "a class def can only have at most one base class declaration and one generic declaration"', nac3artiq/src/lib.rs:378:44 ``` Removing the ``Experiment`` ancestor works around the problem.

sb10q commented

2021-11-10 12:36:21 +08:00

Should we just ignore ancestor classes that are not decorated with @nac3?

Doing it naively may not be a good idea because it would silently ignore ancestors where the user made a typo in the class name. If we go this route we should at least check that the ancestor class exists on the CPython side and raise an error if it does not.

> Should we just ignore ancestor classes that are not decorated with @nac3? Doing it naively may not be a good idea because it would silently ignore ancestors where the user made a typo in the class name. If we go this route we should at least check that the ancestor class exists on the CPython side and raise an error if it does not.

ychenfo commented

2021-11-10 13:06:46 +08:00

Currently in nac3core, the @nac3 annotated classes only allow single inheritance to prevent some troubles from multiple inheritance.(I am not sure... but should we relax this limitation to allow multiple inheritance, but only permit the cases that at most one of the base classes can be constructed on the kernel (have their constructor annotated by @kernel)?)

For nac3artiq, I think if the user made a typo, the python interpreter would complain so we can safely ignore those not decorated with @nac3 and do not check anything in nac3core?

For nac3standalone, I think the check is still necessary now and it would not be a good idea if we ignore them...

So maybe the nac3core needs to have two modes? Under the mode for nac3artiq it ignores the base class not decorated in @nac3, under the mode for standalone it does not?

Currently in nac3core, the `@nac3` annotated classes only allow single inheritance to prevent some troubles from multiple inheritance.(I am not sure... but should we relax this limitation to allow multiple inheritance, but only permit the cases that at most one of the base classes can be constructed on the kernel (have their constructor annotated by `@kernel`)?) For nac3artiq, I think if the user made a typo, the python interpreter would complain so we can safely ignore those not decorated with `@nac3` and do not check anything in nac3core? For nac3standalone, I think the check is still necessary now and it would not be a good idea if we ignore them... So maybe the nac3core needs to have two modes? Under the mode for nac3artiq it ignores the base class not decorated in `@nac3`, under the mode for standalone it does not?

pca006132 commented

2021-11-10 15:22:49 +08:00

What about filtering out ancestor classes that are not decorated with nac3 in nac3artiq? Just a set of class python IDs that are annotated with nac3, so we can filter out those that are not annotated.