support strings as type annotations #73

New Issue

sb10q · 2021-11-05T17:23:00+08:00

sb10q commented

2021-11-05 17:23:00 +08:00

No description provided.

sb10q added the

low-priority

label 2021-11-20 11:03:40 +08:00

ychenfo was assigned by sb10q

2021-11-20 11:03:48 +08:00

sb10q commented

2021-11-20 11:06:50 +08:00

The whole forward reference / string type annotations business seems a bit messy for now, and in flux in Python...

From https://docs.python.org/3/library/typing.html:

Note
get_type_hints() does not work with imported type aliases that include forward references. Enabling postponed evaluation of annotations (PEP 563) may remove the need for most forward references.

Note
PEP 585 generic types such as list["SomeClass"] will not be implicitly transformed into list[ForwardRef("SomeClass")] and thus will not automatically resolve to list[SomeClass].

The latest on the topic seems to be https://www.python.org/dev/peps/pep-0649/.
Let's table this for now and when the time comes see what Python decided. If PEP649 is adopted, patching our Python to enable it without waiting for a release is fine.

The whole forward reference / string type annotations business seems a bit messy for now, and in flux in Python... From https://docs.python.org/3/library/typing.html: ``` Note get_type_hints() does not work with imported type aliases that include forward references. Enabling postponed evaluation of annotations (PEP 563) may remove the need for most forward references. ``` ``` Note PEP 585 generic types such as list["SomeClass"] will not be implicitly transformed into list[ForwardRef("SomeClass")] and thus will not automatically resolve to list[SomeClass]. ``` The latest on the topic seems to be https://www.python.org/dev/peps/pep-0649/. Let's table this for now and when the time comes see what Python decided. If PEP649 is adopted, patching our Python to enable it without waiting for a release is fine.

sb10q referenced this issue

2021-11-20 14:05:38 +08:00

TypeVar and virtual support in Symbol Resolver #99

ychenfo referenced this issue

2021-11-20 15:59:29 +08:00

TypeVar and virtual support in Symbol Resolver #99

pca006132 commented

2021-12-18 16:21:09 +08:00

Is this done?

ychenfo commented

2021-12-19 03:06:24 +08:00

Is this done?

Not yet. There seems to be not much progress on this on how Python will resolve this.

> Is this done? Not yet. There seems to be not much progress on this on how Python will resolve this.

sb10q removed the

low-priority

label 2022-02-28 15:53:51 +08:00

sb10q commented

2022-02-28 15:56:30 +08:00

This may be causing problems for the phaser driver (Phaser.channel, PhaserChannel.phaser, PhaserChannel.oscillator attributes)

This may be causing problems for the phaser driver (``Phaser.channel``, ``PhaserChannel.phaser``, ``PhaserChannel.oscillator`` attributes)

sb10q commented

2022-02-28 16:00:08 +08:00

I guess we can simply solve those with from __future__ import annotations into the Phaser driver (https://www.python.org/dev/peps/pep-0563/). NAC3 itself isn't affected by this problem as it has its own parser and resolver for type annotations (correct?) and the CPython annotation data is rarely used.

I guess we can simply solve those with ``from __future__ import annotations`` into the Phaser driver (https://www.python.org/dev/peps/pep-0563/). NAC3 itself isn't affected by this problem as it has its own parser and resolver for type annotations (correct?) and the CPython annotation data is rarely used.

sb10q commented

2022-02-28 16:55:37 +08:00

Seems to work fine and is probably the simplest and best way to solve this problem for now.

sb10q closed this issue

2022-02-28 16:55:38 +08:00

Sign in to join this conversation.