refactor_composer #535

abdul124 · 2024-08-30T18:36:45+08:00

abdul124 commented

2024-08-30 18:36:45 +08:00

The current composer allows inheriting from classes defined later in program, so that the following code compiles:

from __future__ import annotations
class A(B):
    pass
class B:
    pass

After this PR, the above code will raise the exception: NameError: name 'B' is not defined (at src/test.py:3:9). This check only applies to the inheritance, and type annotations will still work i.e.

from __future__ import annotations
class A:
    a: B
class B:
    pass

This removes the possibility of cyclic inheritance and simplifies the process of finding all class ancestors. The PR also fixes up minor issues like disabling default value assignment to self i.e.

class A:
  def __init__(self=1):
    pass

and cleans up the method/field analysis part of class definition analysis.

The current composer allows inheriting from classes defined later in program, so that the following code compiles: ``` from __future__ import annotations class A(B): pass class B: pass ``` After this PR, the above code will raise the exception: `NameError: name 'B' is not defined (at src/test.py:3:9)`. This check only applies to the inheritance, and type annotations will still work i.e. ``` from __future__ import annotations class A: a: B class B: pass ``` This removes the possibility of cyclic inheritance and simplifies the process of finding all class ancestors. The PR also fixes up minor issues like disabling default value assignment to `self` i.e. ``` class A: def __init__(self=1): pass ``` and cleans up the method/field analysis part of class definition analysis.

derppening force-pushed refactor_composer from 5654190503 to 45ae761ed9

2024-10-04 15:14:21 +08:00

Compare

derppening force-pushed refactor_composer from 45ae761ed9 to 279a2014d2

2024-11-25 16:34:04 +08:00

Compare

derppening requested review from derppening 2024-11-26 16:20:58 +08:00

derppening commented

2024-11-26 16:21:17 +08:00

Note to self: Will review this tomorrow.

derppening force-pushed refactor_composer from 279a2014d2 to babc081dbd

2024-11-27 14:32:46 +08:00