poor error message with incorrect method return type #46

New Issue

sb10q · 2021-10-03T17:15:39+08:00

sb10q commented

2021-10-03 17:15:39 +08:00

@kernel
class Foo:
    @kernel
    def blah(self) -> int32:
        pass


def run() -> int32:
    x = Foo()
    return 0

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "expected return type of class0 in function `__main__Foo.blah`"', nac3standalone/src/main.rs:65:35

class0 does not mean anything to the user.

```python @kernel class Foo: @kernel def blah(self) -> int32: pass def run() -> int32: x = Foo() return 0 ``` ``` thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "expected return type of class0 in function `__main__Foo.blah`"', nac3standalone/src/main.rs:65:35 ``` ``class0`` does not mean anything to the user.

ychenfo referenced this issue from a commit

2021-10-03 18:02:47 +08:00

nac3core: fix #46, better toplevel return type error msg

ychenfo closed this issue

2021-10-03 18:02:47 +08:00

ychenfo referenced this issue from a commit

2021-10-03 18:08:41 +08:00

nac3core: fix #46, better toplevel return type error msg

ychenfo commented

2021-10-03 18:11:26 +08:00

now the error msg looks like:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "expected return type of `int32` in function `__main__A.get_a` at line 13 column 5"', nac3standalone/src/main.rs:65:35

now the error msg looks like: ``` thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "expected return type of `int32` in function `__main__A.get_a` at line 13 column 5"', nac3standalone/src/main.rs:65:35 ```

Sign in to join this conversation.

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#46