M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 99 Pull Requests 21 Releases Wiki Activity

Genericize unifier implementation to remove all special case handling for lists and ndarrays #444

New Issue
Open
opened 2024-07-04 15:26:36 +08:00 by derppening · 0 comments
derppening commented 2024-07-04 15:26:36 +08:00
Collaborator
Copy Link

The unifier currently has several locations where there are special case handling for lists and ndarrays, including:

  • get_instantiations, get_subst, subst_map - If we are instantiating a bounded type variable, we currently must use the TypeVarId of the type variable rather than allowing the use of the TypeVarId of the class type parameter.
  • get_intersection - The intersection for TObj types are currently too lax, causing class types with different type variables to be treated as an intersection result. Moreover, handling for TLiteral is currently missing, causing ndarray typechecks to fail.
The unifier currently has several locations where there are special case handling for lists and ndarrays, including: - `get_instantiations`, `get_subst`, `subst_map` - If we are instantiating a bounded type variable, we currently must use the `TypeVarId` of the type variable rather than allowing the use of the `TypeVarId` of the class type parameter. - `get_intersection` - The intersection for `TObj` types are currently too lax, causing class types with different type variables to be treated as an intersection result. Moreover, handling for `TLiteral` is currently missing, causing `ndarray` typechecks to fail.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
misc/impl-tracert
ndstrides-neo-next
ndstrides-14-end
ndstrides-13-tests
ndstrides-12-builtins
ndstrides-11-matmul
ndstrides-10-ops
ndstrides-9-subassign
ndstrides-8-transpose
ndstrides-7-broadcasting
ndstrides-6-reshape
ndstrides-5-miscfuncs
ndstrides-4-nparray
ndstrides-3-indexing
ndstrides-2-basic
ndstrides-1-model
ndstrides
refactor_composer
misc/update-pyo3
misc/mold
ndstrides-1-model-lifetime
ndstrides-enhance-irrt
ndstrides-intro
issue-313
refactor-primstore
numpy-anyall
enhance/cargo-test-standalone-demos
issue-136
rpc-obj-as-param
iterators
escape-analysis
refactor_anto
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#444
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?