support iteration on lists and tuples #43

New Issue

sb10q · 2021-10-03T16:49:42+08:00

sb10q commented

2021-10-03 16:49:42 +08:00

@extern
def output_int(x: int32):
    ...

def run() -> int32:
    a = [1, 2, 3, 4]
    for x in a:
        output_int(x)
    return 0

currently fails with:

thread '<unnamed>' panicked at 'not implemented: Located { location: Location { row: 7, column: 5 }, custom: None, node: For { target: Located { location: Location { row: 7, column: 9 }, custom: Some(UnificationKey(112)), node: Name { id: "x", ctx: Load } }, iter: Located { location: Location { row: 7, column: 14 }, custom: Some(UnificationKey(111)), node: Name { id: "a", ctx: Load } }, body: [Located { location: Location { row: 8, column: 9 }, custom: None, node: Expr { value: Located { location: Location { row: 8, column: 19 }, custom: Some(UnificationKey(4)), node: Call { func: Located { location: Location { row: 8, column: 9 }, custom: Some(UnificationKey(106)), node: Name { id: "output_int", ctx: Load } }, args: [Located { location: Location { row: 8, column: 20 }, custom: Some(UnificationKey(112)), node: Name { id: "x", ctx: Load } }], keywords: [] } } } }], orelse: [], type_comment: None } }', nac3core/src/codegen/stmt.rs:217:18

```python @extern def output_int(x: int32): ... def run() -> int32: a = [1, 2, 3, 4] for x in a: output_int(x) return 0 ``` currently fails with: ``` thread '<unnamed>' panicked at 'not implemented: Located { location: Location { row: 7, column: 5 }, custom: None, node: For { target: Located { location: Location { row: 7, column: 9 }, custom: Some(UnificationKey(112)), node: Name { id: "x", ctx: Load } }, iter: Located { location: Location { row: 7, column: 14 }, custom: Some(UnificationKey(111)), node: Name { id: "a", ctx: Load } }, body: [Located { location: Location { row: 8, column: 9 }, custom: None, node: Expr { value: Located { location: Location { row: 8, column: 19 }, custom: Some(UnificationKey(4)), node: Call { func: Located { location: Location { row: 8, column: 9 }, custom: Some(UnificationKey(106)), node: Name { id: "output_int", ctx: Load } }, args: [Located { location: Location { row: 8, column: 20 }, custom: Some(UnificationKey(112)), node: Name { id: "x", ctx: Load } }], keywords: [] } } } }], orelse: [], type_comment: None } }', nac3core/src/codegen/stmt.rs:217:18 ```

sb10q changed title from ~~support iteration on lists~~ to support iteration on lists and tuples

2021-10-03 16:50:47 +08:00

sb10q commented

2021-10-03 16:51:36 +08:00

With a tuple, the error is

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "Cannot unify tuple[int32, int32, int32, int32] with list[int32] at line 7 column 14"', nac3standalone/src/main.rs:65:35

We need to decide whether to support it or not on tuples, which can be heterogenous so assigning a type to x isn't always possible.

With a tuple, the error is ``` thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "Cannot unify tuple[int32, int32, int32, int32] with list[int32] at line 7 column 14"', nac3standalone/src/main.rs:65:35 ``` We need to decide whether to support it or not on tuples, which can be heterogenous so assigning a type to ``x`` isn't always possible.

pca006132 commented

2021-10-03 17:59:21 +08:00

tuple requires the loop unfolding feature, which requires the pseudo comment support.