M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 5
Code Issues 89 Pull Requests 7 Releases Wiki Activity

flake: add llvmPackages_14.llvm to devShells linux default #405

Merged
sb10q merged 3 commits from fix-nac3standalone-llvmlink into master 2024-06-05 11:11:57 +08:00
Conversation 3 Commits 3 Files Changed 1 +1 -1
lyken commented 2024-06-03 15:26:28 +08:00
Collaborator
Copy Link

Brings in command llvm-link, used by nac3standalone/demo/run_demo.sh if --lli is on. Otherwise it just fails because llvm-link doesn't exist.

Brings in command `llvm-link`, used by `nac3standalone/demo/run_demo.sh` if `--lli` is on. Otherwise it just fails because llvm-link doesn't exist.
lyken added 1 commit 2024-06-03 15:26:28 +08:00
sb10q commented 2024-06-03 15:56:06 +08:00
Owner
Copy Link
  1. Put it next to line 153 (clang) which is also for running the demos
  2. Make the comments consistently verbose
  3. The tests don't have bintools but still run. Why?
1. Put it next to line 153 (clang) which is also for running the demos 2. Make the comments consistently verbose 3. The tests don't have bintools but still run. Why?
lyken commented 2024-06-03 17:26:00 +08:00
Author
Collaborator
Copy Link
  1. The tests have pkgs.llvmPackages_14.llvm, which also provides llvm-link like bintools, in their nativeBuildInputs. During their checkPhase the pkgs.llvmPackages_14.llvm is still in effect so the command could be found. I am looking into the difference between bintools and just llvmPackages_14.llvm to see if I should use devShells with llvmPackages_14.llvm.out rather than bintools.
3. The tests have `pkgs.llvmPackages_14.llvm`, which also provides `llvm-link` like `bintools`, in their `nativeBuildInputs`. During their `checkPhase` the `pkgs.llvmPackages_14.llvm` is still in effect so the command could be found. I am looking into the difference between `bintools` and just `llvmPackages_14.llvm` to see if I should use devShells with `llvmPackages_14.llvm.out` rather than `bintools`.
sb10q commented 2024-06-03 17:37:14 +08:00
Owner
Copy Link

I think both should use the exact same packages if possible, regardless if it's .bintools or .out.

I think both should use the exact same packages if possible, regardless if it's .bintools or .out.
lyken added 1 commit 2024-06-03 17:39:38 +08:00
lyken changed title from flake: add llvmPackages_14.bintools to devShells linux default to flake: add llvmPackages_14.llvm to devShells linux default 2024-06-04 10:01:36 +08:00
lyken added 1 commit 2024-06-04 10:04:46 +08:00
sb10q merged commit 520bbb246b into master 2024-06-05 11:11:57 +08:00
sb10q deleted branch fix-nac3standalone-llvmlink 2024-06-05 11:12:03 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
UROP0622

   
future-extension

   
high-priority

   
low-priority
No Label
UROP0622
future-extension
high-priority
low-priority
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#405
No description provided.
Delete Branch "fix-nac3standalone-llvmlink"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?