M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 99 Pull Requests 21 Releases Wiki Activity

Collapse all assertions into one fail block #391

New Issue
Closed
opened 2024-03-28 15:53:02 +08:00 by derppening · 1 comment
derppening commented 2024-03-28 15:53:02 +08:00
Collaborator
Copy Link

Currently, each ctx.make_assert call will generate a new fail block for that assertion. Investigate whether it is possible to collapse all these fail blocks into one for greatly reduced code size.

Currently, each `ctx.make_assert` call will generate a new fail block for that assertion. Investigate whether it is possible to collapse all these fail blocks into one for greatly reduced code size.
derppening commented 2024-04-02 17:49:06 +08:00
Author
Collaborator
Copy Link

After looking into this, I think the better way forward is to reduce the number of assertion checks when the input is already sanitized, especially with regards to IRRT helper functions.

After looking into this, I think the better way forward is to reduce the number of assertion checks when the input is already sanitized, especially with regards to IRRT helper functions.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
misc/impl-tracert
ndstrides-neo-next
ndstrides-14-end
ndstrides-13-tests
ndstrides-12-builtins
ndstrides-11-matmul
ndstrides-10-ops
ndstrides-9-subassign
ndstrides-8-transpose
ndstrides-7-broadcasting
ndstrides-6-reshape
ndstrides-5-miscfuncs
ndstrides-4-nparray
ndstrides-3-indexing
ndstrides-2-basic
ndstrides-1-model
ndstrides
refactor_composer
misc/update-pyo3
misc/mold
ndstrides-1-model-lifetime
ndstrides-enhance-irrt
ndstrides-intro
issue-313
refactor-primstore
numpy-anyall
enhance/cargo-test-standalone-demos
issue-136
rpc-obj-as-param
iterators
escape-analysis
refactor_anto
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#391
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?