handle empty __init__ correctly #32

New Issue

pca006132 · 2021-09-28T17:03:39+08:00

pca006132 commented

2021-09-28 17:03:39 +08:00

This should be a host object:

@kernel
class X:
  pass

This should be a device object:

@kernel 
class X:
  @kernel
  def __init__(self):
    pass

This should be a host object: ```python @kernel class X: pass ``` This should be a device object: ```python @kernel class X: @kernel def __init__(self): pass ```

sb10q commented

2021-10-09 11:37:39 +08:00

Related: if __init__ exists and is not decorated with @kernel or @portable, attempting to create the object on the device should fail with a clear error message.

Currently this can either succeed (with the compiler using a default empty __init__) or, if __init__ takes arguments that are correctly passed by the caller, fail with this confusing error:

thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "Too many arguments. at line 10 column 21"', nac3artiq/src/lib.rs:296:44

Related: if ``__init__`` exists and is not decorated with ``@kernel`` or ``@portable``, attempting to create the object on the device should fail with a clear error message. Currently this can either succeed (with the compiler using a default empty ``__init__``) or, if ``__init__`` takes arguments that are correctly passed by the caller, fail with this confusing error: ``` thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "Too many arguments. at line 10 column 21"', nac3artiq/src/lib.rs:296:44 ```

pca006132 referenced this issue from a commit

2021-10-09 16:21:23 +08:00

nac3core: fixes #32 and #57

pca006132 closed this issue

2021-10-09 16:21:23 +08:00

pca006132 referenced this issue

2022-04-13 14:46:57 +08:00

nac3core: toplevel, fix for class constructors + spelling errors #263

Sign in to join this conversation.