nac3artiq: throw error message when constructor use rpc decorator #306

z78078 · 2022-07-08T17:27:57+08:00

z78078 commented

2022-07-08 17:27:57 +08:00

Tested with the following script

from artiq.experiment import *
from artiq.coredevice.core import Core
from artiq.coredevice.ttl import TTLOut

@nac3
class BlinkForever(EnvExperiment):
    core: KernelInvariant[Core]
    led: KernelInvariant[TTLOut]

    @rpc
    def __init__(self, managers_or_parent):
        super().__init__(managers_or_parent)

    def build(self):
        self.setattr_device("core")
        self.setattr_device("led")

    @kernel
    def run(self):
        self.core.reset()
        while True:
            self.led.pulse(100.*ms)
            self.core.delay(100.*ms)

output:

nac3artiq.CompileError: compilation failed
(----------
The constructor of class BlinkForever should not be decorated with rpc decorator (at blink_forever2.py: line 10 column 5)

Tested with the following script ``` from artiq.experiment import * from artiq.coredevice.core import Core from artiq.coredevice.ttl import TTLOut @nac3 class BlinkForever(EnvExperiment): core: KernelInvariant[Core] led: KernelInvariant[TTLOut] @rpc def __init__(self, managers_or_parent): super().__init__(managers_or_parent) def build(self): self.setattr_device("core") self.setattr_device("led") @kernel def run(self): self.core.reset() while True: self.led.pulse(100.*ms) self.core.delay(100.*ms) ``` output: nac3artiq.CompileError: compilation failed (---------- The constructor of class BlinkForever should not be decorated with rpc decorator (at blink_forever2.py: line 10 column 5)

z78078 added 8 commits 2022-07-08 17:27:58 +08:00

update function analyze_single_class_methods_fields in file nac3core/src/toplevel/composer.rs to throw error "class <class-name> constructor __init__ (at <location>) must not be decorated with rpc" when the constructor __init__ is decorated with decorator rpc df9df84879

nac3artiq check if constructor __init__ use rpc decorator 6cba19a50b

nac3artiq check if constructor __init__ use rpc decorator 90d7243bf5

add comment to the code block 74d39be59c

move the changes to nac3artiq cc99085403

move the changes to nac3artiq 5e32724c91

remove unnecesary changes cf45d76668

nac3artiq: add class name to the error message when rpc decorator found in __init__ function 11af619455

z78078 added 1 commit 2022-07-08 17:45:26 +08:00

nac3artiq remove unecessary space 5048977a6b

z78078 changed title from ~~issue-221~~ to nac3artiq: throw error message when constructor use rpc decorator