M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 99 Pull Requests 21 Releases Wiki Activity

ndarray: Implement reshaping #278

New Issue
Open
opened 2022-04-27 10:52:07 +08:00 by sb10q · 1 comment
sb10q commented 2022-04-27 10:52:07 +08:00
Owner
Copy Link

This is trivial in principle, but slightly cumbersome to implement in practice if we want to support wildcards (-1) for an arbitrary number of dimensions, at least if we need to make the compiler emit the necessary code.

(Definitely a solvable issue, but it seems wrong to bake so much logic into the compiler; should probably lower to a runtime function that gets passed a pointer/length pair pointing to the source and target extent tuples.)

Originally posted by @dpn in M-Labs/artiq-zynq#125 (comment)

This is trivial in principle, but slightly cumbersome to implement in practice if we want to support wildcards (`-1`) for an arbitrary number of dimensions, at least if we need to make the compiler emit the necessary code. (Definitely a solvable issue, but it seems wrong to bake so much logic into the compiler; should probably lower to a runtime function that gets passed a pointer/length pair pointing to the source and target extent tuples.) _Originally posted by @dpn in https://git.m-labs.hk/M-Labs/artiq-zynq/issues/125#issue-378_
dpn was assigned by sb10q 2022-04-27 11:00:45 +08:00
dpn was unassigned by sb10q 2024-06-20 15:48:31 +08:00
lyken commented 2024-08-29 09:57:22 +08:00
Collaborator
Copy Link

np_reshape() is currently in master after PR #478 in commit 00236f48bc. -1 is supported.

However, np_reshape() copies the entire array.

`np_reshape()` is currently in `master` after PR https://git.m-labs.hk/M-Labs/nac3/pulls/478 in commit https://git.m-labs.hk/M-Labs/nac3/commit/00236f48bc57c112566edaea4ca36063bb647c7b. `-1` is supported. However, `np_reshape()` copies the entire array.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
misc/impl-tracert
ndstrides-neo-next
ndstrides-14-end
ndstrides-13-tests
ndstrides-12-builtins
ndstrides-11-matmul
ndstrides-10-ops
ndstrides-9-subassign
ndstrides-8-transpose
ndstrides-7-broadcasting
ndstrides-6-reshape
ndstrides-5-miscfuncs
ndstrides-4-nparray
ndstrides-3-indexing
ndstrides-2-basic
ndstrides-1-model
ndstrides
refactor_composer
misc/update-pyo3
misc/mold
ndstrides-1-model-lifetime
ndstrides-enhance-irrt
ndstrides-intro
issue-313
refactor-primstore
numpy-anyall
enhance/cargo-test-standalone-demos
issue-136
rpc-obj-as-param
iterators
escape-analysis
refactor_anto
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#278
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?