review second parameter of create_enum_attribute #269
Labels
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: M-Labs/nac3#269
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I haven't checked if this is a LLVM 14 breaking change or if we were generating invalid IR in the first place, but this now happens:
Attributes look broken. It was supposed to be
noreturn
, notvscale_range(0,1)
. Likely a bug in inkwell or llvm-sys.This can be worked around by commenting out:
Why are we passing 1 there? In this example it's 0:
https://github.com/wasmerio/wasmer/blob/master/lib/compiler-llvm/src/translator/intrinsics.rs#L1047
And using 0 seems to fix the problem.
Cc @pca006132 (
e3032482
)Changed to 0 in
85f21060e4
ah I thought this is something like a bool... idk what its value should be. IIRC there are other some other attributes which may also need to change.
LLVM 14: Attribute \'vscale_range(0,1)\' should have an Argumentto review second parameter of create_enum_attribute