irrt broken when nac3 is built inside msys2 #231

New Issue

sb10q · 2022-03-21T23:09:26+08:00

sb10q commented

2022-03-21 23:09:26 +08:00

LLVM built manually with:

cmake .. -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_UNWIND_TABLES=OFF -DLLVM_ENABLE_THREADS=OFF -DLLVM_TARGETS_TO_BUILD=X86;ARM;RISCV -DLLVM_LINK_LLVM_DYLIB=OFF -DLLVM_ENABLE_FFI=OFF -DLLVM_BUILD_TOOLS=OFF -DLLVM_ENABLE_LIBXML2=OFF -DLLVM_ENABLE_PROJECTS=clang -DCMAKE_INSTALL_PREFIX=Z:\home\sb\msys\mingw64
ninja
ninja llvm-config
copy bin\llvm-config.exe Z:\home\sb\msys\mingw64\bin
ninja llvm-as
copy bin\llvm-as.exe Z:\home\sb\msys\mingw64\bin

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', nac3core\src\codegen\irrt\mod.rs:28:54

LLVM built manually with: ``` cmake .. -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_UNWIND_TABLES=OFF -DLLVM_ENABLE_THREADS=OFF -DLLVM_TARGETS_TO_BUILD=X86;ARM;RISCV -DLLVM_LINK_LLVM_DYLIB=OFF -DLLVM_ENABLE_FFI=OFF -DLLVM_BUILD_TOOLS=OFF -DLLVM_ENABLE_LIBXML2=OFF -DLLVM_ENABLE_PROJECTS=clang -DCMAKE_INSTALL_PREFIX=Z:\home\sb\msys\mingw64 ninja ninja llvm-config copy bin\llvm-config.exe Z:\home\sb\msys\mingw64\bin ninja llvm-as copy bin\llvm-as.exe Z:\home\sb\msys\mingw64\bin ``` ``` thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', nac3core\src\codegen\irrt\mod.rs:28:54 ```

sb10q changed title from ~~iirt broken when nac3 is built inside msys2~~ to irrt broken when nac3 is built inside msys2

2022-03-21 23:09:32 +08:00

sb10q referenced this issue

2022-03-21 23:47:15 +08:00

compile Windows version with Wine + MSYS2 #232

sb10q commented

2022-03-22 09:52:24 +08:00

The iirt.bc has all the functions removed, due to the regex it would seem. ~~But I don't understand how it works on Linux because there is the same problem there.~~

llvm-dis ./target/release/build/nac3core-ac259b5eb89ed6f8/out/irrt.bc -o -
; ModuleID = './target/release/build/nac3core-ac259b5eb89ed6f8/out/irrt.bc'
source_filename = "<stdin>"

; Function Attrs: argmemonly nofree nounwind willreturn
declare void @llvm.memmove.p0i8.p0i8.i32(i8* nocapture writeonly, i8* nocapture readonly, i32, i1 immarg) #0

; Function Attrs: argmemonly nofree nounwind willreturn
declare void @llvm.memcpy.p0i8.p0i8.i32(i8* noalias nocapture writeonly, i8* noalias nocapture readonly, i32, i1 immarg) #0

attributes #0 = { argmemonly nofree nounwind willreturn }

Clang output is identical on Linux and Windows.

The iirt.bc has all the functions removed, due to the regex it would seem. <s>But I don't understand how it works on Linux because there is the same problem there.</s> ``` llvm-dis ./target/release/build/nac3core-ac259b5eb89ed6f8/out/irrt.bc -o - ; ModuleID = './target/release/build/nac3core-ac259b5eb89ed6f8/out/irrt.bc' source_filename = "<stdin>" ; Function Attrs: argmemonly nofree nounwind willreturn declare void @llvm.memmove.p0i8.p0i8.i32(i8* nocapture writeonly, i8* nocapture readonly, i32, i1 immarg) #0 ; Function Attrs: argmemonly nofree nounwind willreturn declare void @llvm.memcpy.p0i8.p0i8.i32(i8* noalias nocapture writeonly, i8* noalias nocapture readonly, i32, i1 immarg) #0 attributes #0 = { argmemonly nofree nounwind willreturn } ``` Clang output is identical on Linux and Windows.

sb10q commented

2022-03-22 10:04:16 +08:00

This makes it work on Windows:

diff --git a/nac3core/build.rs b/nac3core/build.rs
index b2eda85..8cf85e6 100644
--- a/nac3core/build.rs
+++ b/nac3core/build.rs
@@ -56,6 +56,6 @@ fn main() {
         .arg(Path::new(&env::var("OUT_DIR").unwrap()).join("irrt.bc"))
         .spawn()
         .unwrap();
-    llvm_as.stdin.as_mut().unwrap().write_all(filtered_output.as_bytes()).unwrap();
+    llvm_as.stdin.as_mut().unwrap().write_all(output.as_bytes()).unwrap();
     assert!(llvm_as.wait().unwrap().success())
 }

This makes it work on Windows: ``` diff --git a/nac3core/build.rs b/nac3core/build.rs index b2eda85..8cf85e6 100644 --- a/nac3core/build.rs +++ b/nac3core/build.rs @@ -56,6 +56,6 @@ fn main() { .arg(Path::new(&env::var("OUT_DIR").unwrap()).join("irrt.bc")) .spawn() .unwrap(); - llvm_as.stdin.as_mut().unwrap().write_all(filtered_output.as_bytes()).unwrap(); + llvm_as.stdin.as_mut().unwrap().write_all(output.as_bytes()).unwrap(); assert!(llvm_as.wait().unwrap().success()) } ```

sb10q commented

2022-03-22 15:58:06 +08:00