Typevars cause Option::unwrap() on a None value', nac3core/src/codegen/expr.rs:500:51 #229

New Issue

sb10q · 2022-03-20T22:39:36+08:00

sb10q commented

2022-03-20 22:39:36 +08:00

https://github.com/m-labs/artiq/issues/1207

from typing import TypeVar, Generic

from numpy import int32

from artiq.experiment import *
from artiq.coredevice.core import Core


@nac3
class A:
    @kernel
    def do(self) -> int32:
        return 0


@nac3
class B:
    @kernel
    def do(self) -> int32:
        return 1


T = TypeVar("T", A, B)


@nac3
class C(Generic[T]):
    sub: Kernel[T]

    def __init__(self, which):
        if which:
            self.sub = B()
        else:
            self.sub = A()

    @kernel
    def do(self) -> int32:
        return self.sub.do()


U = TypeVar("U", C[A], C[B])

@nac3
class Types(Generic[U], EnvExperiment):
    core: KernelInvariant[Core]
    c0: Kernel[U]
    c1: Kernel[U]
    
    def build(self):
        self.setattr_device("core")
        self.c0 = C(False)
        self.c1 = C(True)
    
    @kernel
    def run(self):
        print_rpc(self.c0.do() + self.c1.do())

thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None` value', nac3core/src/codegen/expr.rs:500:51

https://github.com/m-labs/artiq/issues/1207 ```python from typing import TypeVar, Generic from numpy import int32 from artiq.experiment import * from artiq.coredevice.core import Core @nac3 class A: @kernel def do(self) -> int32: return 0 @nac3 class B: @kernel def do(self) -> int32: return 1 T = TypeVar("T", A, B) @nac3 class C(Generic[T]): sub: Kernel[T] def __init__(self, which): if which: self.sub = B() else: self.sub = A() @kernel def do(self) -> int32: return self.sub.do() U = TypeVar("U", C[A], C[B]) @nac3 class Types(Generic[U], EnvExperiment): core: KernelInvariant[Core] c0: Kernel[U] c1: Kernel[U] def build(self): self.setattr_device("core") self.c0 = C(False) self.c1 = C(True) @kernel def run(self): print_rpc(self.c0.do() + self.c1.do()) ``` ``` thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None` value', nac3core/src/codegen/expr.rs:500:51 ```

sb10q commented

2022-03-20 22:42:17 +08:00

(This is probably not the right way to use Typevar/Generic, regardless it should not panic)

pca006132 closed this issue

2022-03-23 00:25:33 +08:00

pca006132 reopened this issue

2022-03-23 00:42:45 +08:00

pca006132 commented

2022-03-23 00:44:30 +08:00

btw the code is wrong: you should use

U = TypeVar("U", C[A], C[B])
U2 = TypeVar("U", C[A], C[B])

@nac3
class Types(Generic[U2], EnvExperiment):
    core: KernelInvariant[Core]
    c0: Kernel[U]
    c1: Kernel[U2]

Otherwise the type of c0 and c1 will be the same.

btw the code is wrong: you should use ```python U = TypeVar("U", C[A], C[B]) U2 = TypeVar("U", C[A], C[B]) @nac3 class Types(Generic[U2], EnvExperiment): core: KernelInvariant[Core] c0: Kernel[U] c1: Kernel[U2] ``` Otherwise the type of c0 and c1 will be the same.

sb10q commented

2022-03-23 08:49:29 +08:00

U = TypeVar("U", C[A], C[B])
V = TypeVar("V", C[A], C[B])

@nac3
class Types(Generic[U, V], EnvExperiment):
    core: KernelInvariant[Core]
    c0: Kernel[U]
    c1: Kernel[V]

still causes the Rust panic at the same spot.

```python U = TypeVar("U", C[A], C[B]) V = TypeVar("V", C[A], C[B]) @nac3 class Types(Generic[U, V], EnvExperiment): core: KernelInvariant[Core] c0: Kernel[U] c1: Kernel[V] ``` still causes the Rust panic at the same spot.

pca006132 commented

2022-03-23 16:30:24 +08:00

Yes, I'm debugging the issue.

pca006132 referenced this issue

2022-03-24 21:35:11 +08:00

Fixed typevar with fixed range #238

sb10q closed this issue

2022-03-24 22:23:30 +08:00

Sign in to join this conversation.