M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 97 Pull Requests 19 Releases Wiki Activity

phaser driver causes nac3 segfault #202

New Issue
Closed
opened 2022-02-28 17:02:08 +08:00 by sb10q · 5 comments
sb10q commented 2022-02-28 17:02:08 +08:00
Owner
Copy Link

ARTIQ ea55c29568bacddf7e2faedc5c686fe351ac5b12

Uncomment the two # NAC3TODO segfault lines in nac3devices.py.

> artiq_compile nac3devices.py
fish: Job 1, 'artiq_compile nac3devices.py' terminated by signal SIGSEGV (Address boundary error)
ARTIQ ea55c29568bacddf7e2faedc5c686fe351ac5b12 Uncomment the two ``# NAC3TODO segfault`` lines in nac3devices.py. ``` > artiq_compile nac3devices.py fish: Job 1, 'artiq_compile nac3devices.py' terminated by signal SIGSEGV (Address boundary error) ```
sb10q added this to the Prealpha milestone 2022-02-28 17:02:08 +08:00
sb10q added the
high-priority
 label 2022-02-28 17:02:08 +08:00
pca006132 was assigned by sb10q 2022-02-28 17:02:08 +08:00
sb10q commented 2022-02-28 17:06:36 +08:00
Author
Owner
Copy Link

(Still segfaults after fixing the incorrect Fastino annotation)

(Still segfaults after fixing the incorrect ``Fastino`` annotation)
sb10q commented 2022-02-28 17:10:49 +08:00
Author
Owner
Copy Link

Removing the channel: Kernel[list[PhaserChannel]] attribute initialized by the host stops the segfault and compilation completes.

Removing the ``channel: Kernel[list[PhaserChannel]]`` attribute initialized by the host stops the segfault and compilation completes.
phasersegfault.diff
7.7 KiB
pca006132 commented 2022-02-28 21:50:24 +08:00
Contributor
Copy Link

Looks like the problem is due to reference cycles. Will fix.

Looks like the problem is due to reference cycles. Will fix.
pca006132 commented 2022-02-28 23:11:05 +08:00
Contributor
Copy Link

Fixed the cyclic reference issue. Apart from that, it seems that the port has type error: thread '<unnamed>' panicked at 'Codegen error: CompileError: Error getting field phaser0: CompileError: Error getting field channel: CompileError: Error getting element 0: CompileError: Error getting field trf_mmap: CompileError: Error getting element 5: CompileError: 2425360398 is not in the range of int32', /home/pca006132/code/rust/nac3/nac3core/src/codegen/mod.rs:225:13

btw I am thinking about how to improve this error message...

Fixed the cyclic reference issue. Apart from that, it seems that the port has type error: `thread '<unnamed>' panicked at 'Codegen error: CompileError: Error getting field phaser0: CompileError: Error getting field channel: CompileError: Error getting element 0: CompileError: Error getting field trf_mmap: CompileError: Error getting element 5: CompileError: 2425360398 is not in the range of int32', /home/pca006132/code/rust/nac3/nac3core/src/codegen/mod.rs:225:13` btw I am thinking about how to improve this error message...
sb10q commented 2022-03-01 09:53:45 +08:00
Author
Owner
Copy Link

That's a bit annoying, the list should contain that value indeed. The best solution would be #14 ...

That's a bit annoying, the list should contain that value indeed. The best solution would be https://git.m-labs.hk/M-Labs/nac3/issues/14 ...
sb10q closed this issue 2022-03-01 11:47:05 +08:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
refactor_composer
misc/impl-tracert
ndstrides-neo-next
ndstrides-14-end
ndstrides-13-tests
ndstrides-12-builtins
ndstrides-11-matmul
ndstrides-10-ops
ndstrides-9-subassign
ndstrides-8-transpose
ndstrides-7-broadcasting
ndstrides-6-reshape
ndstrides-5-miscfuncs
ndstrides-4-nparray
ndstrides-3-indexing
ndstrides-2-basic
ndstrides-1-model
ndstrides-base
misc/update-pyo3
misc/mold
ndstrides-1-model-lifetime
ndstrides-enhance-irrt
ndstrides-intro
issue-313
refactor-primstore
numpy-anyall
enhance/cargo-test-standalone-demos
issue-136
rpc-obj-as-param
iterators
escape-analysis
refactor_anto
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Prealpha
Assignees
Clear assignees
No Assignees
pca006132
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#202
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?