review artiq_builtin = True in ARTIQ exceptions #191

New Issue

sb10q · 2022-02-13T12:30:59+08:00

sb10q commented

2022-02-13 12:30:59 +08:00

In the legacy code, some exceptions are defined as:

class RTIODestinationUnreachable(Exception):
    artiq_builtin = True

Figure out what artiq_builtin does and if NAC3 needs it.

In the legacy code, some exceptions are defined as: ``` class RTIODestinationUnreachable(Exception): artiq_builtin = True ``` Figure out what ``artiq_builtin`` does and if NAC3 needs it.

sb10q changed title from ~~review ``artiq_builtin = True`` in ARTIQ exceptions~~ to review `artiq_builtin = True` in ARTIQ exceptions

2022-02-13 12:31:08 +08:00

pca006132 commented

2022-03-05 00:31:01 +08:00

We need this to indicate that the exception is an builtin exception with object ID 0, so the name is synchronized with the firmware.

sb10q added this to the Prealpha milestone 2022-03-05 10:15:49 +08:00

sb10q commented

2022-03-05 22:29:43 +08:00

Probably related: currently there is no core device traceback for built-in exceptions.

Traceback (most recent call last):
  File "/nix/store/wzfg1fm9kalmg5zxrc109siarxp09kmg-python3.9-artiq-8.0.unknown.beta/bin/.artiq_sinara_tester-wrapped", line 9, in <module>
    sys.exit(main())
  File "/home/sb/artiq/artiq/frontend/artiq_sinara_tester.py", line 808, in main
    experiment.run(tests)
  File "/home/sb/artiq/artiq/frontend/artiq_sinara_tester.py", line 759, in run
    getattr(self, f"test_{name}")()
  File "/home/sb/artiq/artiq/frontend/artiq_sinara_tester.py", line 332, in test_urukuls
    self.setup_urukul(channel_dev, float(frequency))
  File "/home/sb/artiq/artiq/language/core.py", line 75, in run_on_core
    self.core.run(fake_method, args, kwargs)
  File "/home/sb/artiq/artiq/coredevice/core.py", line 92, in run
    self.comm.serve(self.embedding_map, symbolizer)
  File "/home/sb/artiq/artiq/coredevice/comm_kernel.py", line 800, in serve
    self._serve_exception(embedding_map, symbolizer)
  File "/home/sb/artiq/artiq/coredevice/comm_kernel.py", line 782, in _serve_exception
    raise python_exn
artiq.coredevice.exceptions.RTIOUnderflow: RTIO underflow at 365749848 mu, channel 0, slack -777387087480 mu

Probably related: currently there is no core device traceback for built-in exceptions. ``` Traceback (most recent call last): File "/nix/store/wzfg1fm9kalmg5zxrc109siarxp09kmg-python3.9-artiq-8.0.unknown.beta/bin/.artiq_sinara_tester-wrapped", line 9, in <module> sys.exit(main()) File "/home/sb/artiq/artiq/frontend/artiq_sinara_tester.py", line 808, in main experiment.run(tests) File "/home/sb/artiq/artiq/frontend/artiq_sinara_tester.py", line 759, in run getattr(self, f"test_{name}")() File "/home/sb/artiq/artiq/frontend/artiq_sinara_tester.py", line 332, in test_urukuls self.setup_urukul(channel_dev, float(frequency)) File "/home/sb/artiq/artiq/language/core.py", line 75, in run_on_core self.core.run(fake_method, args, kwargs) File "/home/sb/artiq/artiq/coredevice/core.py", line 92, in run self.comm.serve(self.embedding_map, symbolizer) File "/home/sb/artiq/artiq/coredevice/comm_kernel.py", line 800, in serve self._serve_exception(embedding_map, symbolizer) File "/home/sb/artiq/artiq/coredevice/comm_kernel.py", line 782, in _serve_exception raise python_exn artiq.coredevice.exceptions.RTIOUnderflow: RTIO underflow at 365749848 mu, channel 0, slack -777387087480 mu ```

sb10q added the

high-priority

label 2022-03-16 09:55:39 +08:00

pca006132 was assigned by sb10q

2022-03-16 09:55:43 +08:00

pca006132 commented

2022-03-17 15:09:00 +08:00

Also fixed in #218

pca006132 closed this issue

2022-03-17 15:09:00 +08:00

Sign in to join this conversation.