dead code is not an error #118

New Issue

sb10q · 2021-11-29T18:02:29+08:00

sb10q commented

2021-11-29 18:02:29 +08:00

During debugging, it is useful to insert a return statement in the middle of a function.
Currently this fails with thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "dead code at Location { row: 116, column: 13 }"', nac3artiq/src/lib.rs:447:44

This should be demoted to a warning and the compilation should continue.

During debugging, it is useful to insert a return statement in the middle of a function. Currently this fails with ``thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "dead code at Location { row: 116, column: 13 }"', nac3artiq/src/lib.rs:447:44`` This should be demoted to a warning and the compilation should continue.

ychenfo was assigned by sb10q

2021-12-21 19:11:29 +08:00

pca006132 referenced this issue

2022-02-13 13:37:40 +08:00

deterministic error message #190

sb10q added this to the Beta milestone 2022-04-12 11:04:15 +08:00

sb10q commented

2022-04-12 11:04:26 +08:00

And generally: how should we report warnings?

ychenfo commented

2022-04-12 16:00:16 +08:00

And generally: how should we report warnings?

iirc currently the only functions that need to return warnings are check_blocks and check_stmts, whose return types are Result<bool, String>. Maybe we can change it to something like Result<(bool, Vec<WarningMsg>), String>? and just print out the sorted warning messages if nac3 is not configured to suppress warnings.

> And generally: how should we report warnings? iirc currently the only functions that need to return warnings are `check_blocks` and `check_stmts`, whose return types are `Result<bool, String>`. Maybe we can change it to something like `Result<(bool, Vec<WarningMsg>), String>`? and just print out the sorted warning messages if nac3 is not configured to suppress warnings.

pca006132 commented

2022-04-12 20:23:47 +08:00

I think we should implement something like the diagnostic class in the legacy compiler. Returning an result will only work for errors.

derppening referenced this issue

2023-09-29 17:52:35 +08:00

Demote dead code into a stdout warning #328

sb10q closed this issue

2023-10-04 21:30:43 +08:00

Sign in to join this conversation.