location missing from unsupported class body statement error #112

New Issue

sb10q · 2021-11-23T17:52:33+08:00

sb10q commented

2021-11-23 17:52:33 +08:00

pyo3_runtime.PanicException: called `Result::unwrap()` on an `Err` value: "unsupported statement type in class definition body"

``` pyo3_runtime.PanicException: called `Result::unwrap()` on an `Err` value: "unsupported statement type in class definition body" ```

ychenfo referenced this issue from a commit

2021-11-26 04:32:26 +08:00

nac3core: error msg add location in some trivial cases (#112, #110, #108, #87)

sb10q commented

2021-12-21 19:01:54 +08:00

@ychenfo is there still more work you need to do in that err_msg_improvement branch or should we merge?

ychenfo commented

2021-12-22 02:48:35 +08:00

@ychenfo is there still more work you need to do in that err_msg_improvement branch or should we merge?

Oh I think merging this should solve these practical issues mentioned. Previously I tabled this because I plan to add file name in this branch, now we add file name to the AST so I think this branch can be merged first?

After adding file names some of the error messages improvements in this patch will need to be revisited though, I can send another patch for it after adding file name in AST.

> @ychenfo is there still more work you need to do in that err_msg_improvement branch or should we merge? Oh I think merging this should solve these practical issues mentioned. Previously I tabled this because I plan to add file name in this branch, now we add file name to the AST so I think this branch can be merged first? After adding file names some of the error messages improvements in this patch will need to be revisited though, I can send another patch for it after adding file name in AST.

ychenfo referenced this issue

2021-12-22 02:56:01 +08:00

Add Error Message Location (#112, #110, #108, #87); Some Minor Error Message Improvements #145

sb10q referenced this issue from a commit

2021-12-22 08:52:20 +08:00

improve error messages

sb10q commented

2021-12-22 08:53:01 +08:00

Previously I tabled this because I plan to add file name in this branch, now we add file name to the AST so I think this branch can be merged first?

It is generally better to avoid bundling too many things into one PR anyway.

> Previously I tabled this because I plan to add file name in this branch, now we add file name to the AST so I think this branch can be merged first? It is generally better to avoid bundling too many things into one PR anyway.

sb10q closed this issue

2021-12-22 08:53:18 +08:00

ychenfo referenced this issue from a commit

2021-12-27 16:57:43 +08:00

improve error messages

Sign in to join this conversation.