poor error message with tuple indexing #109

New Issue

sb10q · 2021-11-23T17:04:57+08:00

sb10q commented

2021-11-23 17:04:57 +08:00

clk_sel_hw_rev: KernelInvariant[tuple[int32, int32, int32, int32]]
clk_sel: int32
...
self.clk_sel = self.clk_sel_hw_rev[self.hw_rev]

pyo3_runtime.PanicException: called `Result::unwrap()` on an `Err` value: "Cannot unify list[var533] with tuple[int32, int32, int32, int32] at line 124 column 28"

var533 should be replaced.

``` clk_sel_hw_rev: KernelInvariant[tuple[int32, int32, int32, int32]] clk_sel: int32 ... self.clk_sel = self.clk_sel_hw_rev[self.hw_rev] ``` ``` pyo3_runtime.PanicException: called `Result::unwrap()` on an `Err` value: "Cannot unify list[var533] with tuple[int32, int32, int32, int32] at line 124 column 28" ``` ``var533`` should be replaced.

pca006132 referenced this issue

2022-02-21 18:43:18 +08:00

Better error messages #195

sb10q commented

2022-02-22 16:05:58 +08:00

Poster

Still broken (but in a different way).
Try this demo.py:

from min_artiq import *
from numpy import int32


@nac3
class Demo:
    core: KernelInvariant[Core]
    clk_sel_hw_rev: KernelInvariant[tuple[int32, int32, int32, int32]]
    clk_sel: int32

    def __init__(self):
        self.core = Core()
        self.clk_sel_hw_rev = (1, 2, 3, 4)
        self.clk_sel = 2

    @kernel
    def run(self):
        self.clk_sel = self.clk_sel_hw_rev[self.hw_rev]


if __name__ == "__main__":
    Demo().run()

RuntimeError: type error inside object launching kernel: error when getting type of field `clk_sel_hw_rev` (Incompatible types: tuple[int32, int32, int32, int32] and Exception)

Still broken (but in a different way). Try this ``demo.py``: ```python from min_artiq import * from numpy import int32 @nac3 class Demo: core: KernelInvariant[Core] clk_sel_hw_rev: KernelInvariant[tuple[int32, int32, int32, int32]] clk_sel: int32 def __init__(self): self.core = Core() self.clk_sel_hw_rev = (1, 2, 3, 4) self.clk_sel = 2 @kernel def run(self): self.clk_sel = self.clk_sel_hw_rev[self.hw_rev] if __name__ == "__main__": Demo().run() ``` ``` RuntimeError: type error inside object launching kernel: error when getting type of field `clk_sel_hw_rev` (Incompatible types: tuple[int32, int32, int32, int32] and Exception) ```

sb10q commented

2022-02-22 16:10:13 +08:00

Poster

Note that filename and line number are also missing from the message, in addition to the incorrect reference to Exception.

Note that filename and line number are also missing from the message, in addition to the incorrect reference to ``Exception``.

sb10q added the

high-priority

label 2022-02-22 16:29:22 +08:00

sb10q added this to the Prealpha milestone 2022-02-22 16:29:25 +08:00

pca006132 commented

2022-02-22 17:01:36 +08:00

Well I guess this is due to constant folding and I forgot to add special case for that. Will fix.