poor error message for wrong 1-tuple annotation #108

New Issue

sb10q · 2021-11-23T15:48:48+08:00

sb10q commented

2021-11-23 15:48:48 +08:00

x: tuple[int32] annotations error out with pyo3_runtime.PanicException: called `Result::unwrap()` on an `Err` value: "Expect multiple elements for tuple"

We should not panic from errors in user code
Location should be indicated
Error message should be clearer and indicate the correct syntax for 1-tuple: tuple[(ty, )]. Alternatively we can also accept tuple[ty] for 1-tuples.

``x: tuple[int32]`` annotations error out with ``pyo3_runtime.PanicException: called `Result::unwrap()` on an `Err` value: "Expect multiple elements for tuple"`` 1. We should not panic from errors in user code 2. Location should be indicated 3. Error message should be clearer and indicate the correct syntax for 1-tuple: ``tuple[(ty, )]``. Alternatively we can also accept ``tuple[ty]`` for 1-tuples.

ychenfo referenced this issue from a commit

2021-11-26 04:32:26 +08:00

nac3core: error msg add location in some trivial cases (#112, #110, #108, #87)

ychenfo commented

2021-11-26 04:39:23 +08:00

We should not panic from errors in user code

I am sorry that regarding this I am not sure how this should be handled.. since it is an error ultimately captured and unwraped in a rust code that is called from python. Are we able to raise a python error from rust or did I miss anything?

> We should not panic from errors in user code I am sorry that regarding this I am not sure how this should be handled.. since it is an error ultimately captured and unwraped in a rust code that is called from python. Are we able to raise a python error from rust or did I miss anything?

sb10q commented

2021-11-26 08:21:51 +08:00

Are we able to raise a python error from rust or did I miss anything?

Absolutely - when PyO3 functions return a PyResult, Err values are turned into exceptions.
Example: https://git.m-labs.hk/M-Labs/nac3/src/branch/master/nac3artiq/src/lib.rs#L97-L101

> Are we able to raise a python error from rust or did I miss anything? Absolutely - when PyO3 functions return a ``PyResult``, ``Err`` values are turned into exceptions. Example: https://git.m-labs.hk/M-Labs/nac3/src/branch/master/nac3artiq/src/lib.rs#L97-L101

ychenfo referenced this issue from a commit

2021-12-01 02:29:07 +08:00

nac3artiq: raise a python runtime exception instead of panic for compilation error (#108)

ychenfo referenced this issue from a commit

2021-12-01 02:32:04 +08:00

nac3artiq: raise a python runtime exception instead of panic for compilation error (#108)

ychenfo referenced this issue

2021-12-22 02:56:01 +08:00

Add Error Message Location (#112, #110, #108, #87); Some Minor Error Message Improvements #145

sb10q referenced this issue from a commit

2021-12-22 08:52:20 +08:00

improve error messages