support class attributes #102

New Issue

sb10q · 2021-11-19T12:55:12+08:00

sb10q commented

2021-11-19 12:55:12 +08:00

e.g.

class Foo:
   MY_ATTR = 32

e.g. ```python class Foo: MY_ATTR = 32 ```

sb10q added the

low-priority

label 2021-11-19 12:55:12 +08:00

sb10q added the

UROP0622

label 2022-06-24 18:03:41 +08:00

sb10q commented

2022-07-19 10:29:38 +08:00

Needs to be supported in nac3artiq + nac3standalone

Need to find a way to annotate it in nac3artiq. How about something like

class Foo:
   MY_ATTR0 = 32 # host only
   MY_ATTR1: int32 = 32  # host only
   MY_ATTR2: KernelInvariant[int32] = 32  # accessible to the kernel
   MY_ATTR3: Kernel[int32] = 32  # do we want to support this? OK if such attributes are immutable

Needs to be supported in nac3artiq + nac3standalone Need to find a way to annotate it in nac3artiq. How about something like ```python class Foo: MY_ATTR0 = 32 # host only MY_ATTR1: int32 = 32 # host only MY_ATTR2: KernelInvariant[int32] = 32 # accessible to the kernel MY_ATTR3: Kernel[int32] = 32 # do we want to support this? OK if such attributes are immutable ```

sb10q commented

2022-07-19 10:32:27 +08:00

Example code (nac3artiq) that should work but does not:

from artiq.experiment import *
from artiq.coredevice.core import Core


@nac3
class XXX:
    TEST: KernelInvariant[int32] = 32

@nac3
class NAC3Devices(EnvExperiment):
    core: KernelInvariant[Core]

    YYY: KernelInvariant[int32] = 32

    def build(self):
        self.setattr_device("core")

    @kernel
    def run(self):
        print_rpc(XXX.TEST)
        print_rpc(self.YYY)
        print_rpc(NAC3Devices.YYY)

Example code (nac3artiq) that should work but does not: ```python from artiq.experiment import * from artiq.coredevice.core import Core @nac3 class XXX: TEST: KernelInvariant[int32] = 32 @nac3 class NAC3Devices(EnvExperiment): core: KernelInvariant[Core] YYY: KernelInvariant[int32] = 32 def build(self): self.setattr_device("core") @kernel def run(self): print_rpc(XXX.TEST) print_rpc(self.YYY) print_rpc(NAC3Devices.YYY) ```

sb10q removed the

UROP0622

label 2024-06-03 09:44:00 +08:00

abdul124 was assigned by sb10q

2024-06-03 09:57:14 +08:00

abdul124 added reference support_class_attribute_issue102

2024-06-07 17:29:12 +08:00

abdul124 referenced this issue

2024-06-14 15:51:08 +08:00

WIP: nac3artiq: add support for class objects without __init__ method #417

abdul124 referenced this issue

2024-06-14 16:02:03 +08:00

WIP: support_string_class_attr #415

abdul124 changed reference from ~~support_class_attribute_issue102~~ to issue-102

2024-06-19 18:05:39 +08:00

abdul124 referenced this issue

2024-06-20 13:22:09 +08:00

core: add support for class attributes (issue-102) #425

abdul124 commented

2024-06-27 11:09:05 +08:00

Realized by #425

abdul124 closed this issue

2024-06-27 11:09:07 +08:00

sb10q commented

2024-06-27 11:27:34 +08:00

Are all the various examples given in this Issue tested and working?

abdul124 commented

2024-06-27 11:42:58 +08:00

from min_artiq import *
from numpy import int32

@nac3
class Demo:
    attr1: KernelInvariant[int32] = 2
    attr2: int32 = 4
    attr3: Kernel[int32]

    @kernel
    def __init__(self):
        self.attr3 = 8

@nac3
class NAC3Devices:
    core: KernelInvariant[Core]
    attr4: KernelInvariant[int32] = 16
    
    def __init__(self):
        self.core = Core()

    @kernel
    def run(self):
        Demo.attr1  # Supported
        # Demo.attr2  # Field not accessible on Kernel
        # Demo.attr3  # Only attributes can be accessed in this way
        # Demo.attr1 = 2  # Attributes are immutable

        self.attr4  # Attributes can be accessed within class

        obj = Demo()
        obj.attr1  # Attributes can be accessed by class objects

        NAC3Devices.attr4  # Attributes accessible for classes without __init__

if __name__ == "__main__":
    NAC3Devices().run()

This program shows the current behavior. The attributes are all treated as immutable (whether defined as Kernel or KernelInvariant).

``` from min_artiq import * from numpy import int32 @nac3 class Demo: attr1: KernelInvariant[int32] = 2 attr2: int32 = 4 attr3: Kernel[int32] @kernel def __init__(self): self.attr3 = 8 @nac3 class NAC3Devices: core: KernelInvariant[Core] attr4: KernelInvariant[int32] = 16 def __init__(self): self.core = Core() @kernel def run(self): Demo.attr1 # Supported # Demo.attr2 # Field not accessible on Kernel # Demo.attr3 # Only attributes can be accessed in this way # Demo.attr1 = 2 # Attributes are immutable self.attr4 # Attributes can be accessed within class obj = Demo() obj.attr1 # Attributes can be accessed by class objects NAC3Devices.attr4 # Attributes accessible for classes without __init__ if __name__ == "__main__": NAC3Devices().run() ``` This program shows the current behavior. The attributes are all treated as immutable (whether defined as Kernel or KernelInvariant).

Sign in to join this conversation.