pass statement support #10

New Issue

sb10q · 2021-09-20T11:49:55+08:00

sb10q commented

2021-09-20 11:49:55 +08:00

Using pass fails with thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "Unsupported statement type"', nac3standalone/src/main.rs:72:35

Using ``pass`` fails with ``thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "Unsupported statement type"', nac3standalone/src/main.rs:72:35``

pca006132 commented

2021-09-21 11:32:29 +08:00

Supported now in 20905a9b67 ?
@ychenfo

Supported now in 20905a9b67af0f8128d4e7f19de039e54c682df4 ? @ychenfo

ychenfo commented

2021-09-21 13:21:35 +08:00

Supported now in 20905a9b67 ?
@ychenfo

I do not think so, I think it is related here. The fix should be trivial, though, just add a case of pass statement here?

I tried to fix it in the latest commit in 1c170f5c41. It seems ok now.

> Supported now in 20905a9b67af0f8128d4e7f19de039e54c682df4 ? > @ychenfo I do not think so, I think it is related [here](https://git.m-labs.hk/M-Labs/nac3/src/branch/standalone_composer/nac3core/src/typecheck/type_inferencer/mod.rs#L144). The fix should be trivial, though, just add a case of `pass` statement [here](https://git.m-labs.hk/M-Labs/nac3/src/branch/standalone_composer/nac3core/src/typecheck/type_inferencer/mod.rs#L131)? I tried to fix it in the latest commit in https://git.m-labs.hk/M-Labs/nac3/commit/1c170f5c411ab305f6466748c3819c1b768c79b4. It seems ok now.

sb10q referenced this issue from a commit

2021-09-22 15:17:19 +08:00

codegen: support pass statement. Closes #10

sb10q closed this issue

2021-09-22 15:17:19 +08:00

Sign in to join this conversation.