M-Labs/nac3
M-Labs/nac3
8
1
Fork 12
Code Issues 98 Pull Requests 19 Releases Wiki Activity

pass statement support #10

New Issue
Closed
opened 2021-09-20 11:49:55 +08:00 by sb10q · 2 comments
sb10q commented 2021-09-20 11:49:55 +08:00
Owner
Copy Link

Using pass fails with thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "Unsupported statement type"', nac3standalone/src/main.rs:72:35

Using ``pass`` fails with ``thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "Unsupported statement type"', nac3standalone/src/main.rs:72:35``
pca006132 commented 2021-09-21 11:32:29 +08:00
Contributor
Copy Link

Supported now in 20905a9b67 ?
@ychenfo

Supported now in 20905a9b67af0f8128d4e7f19de039e54c682df4 ? @ychenfo
ychenfo commented 2021-09-21 13:21:35 +08:00
Collaborator
Copy Link

Supported now in 20905a9b67 ?
@ychenfo

I do not think so, I think it is related here. The fix should be trivial, though, just add a case of pass statement here?

I tried to fix it in the latest commit in 1c170f5c41. It seems ok now.

> Supported now in 20905a9b67af0f8128d4e7f19de039e54c682df4 ? > @ychenfo I do not think so, I think it is related [here](https://git.m-labs.hk/M-Labs/nac3/src/branch/standalone_composer/nac3core/src/typecheck/type_inferencer/mod.rs#L144). The fix should be trivial, though, just add a case of `pass` statement [here](https://git.m-labs.hk/M-Labs/nac3/src/branch/standalone_composer/nac3core/src/typecheck/type_inferencer/mod.rs#L131)? I tried to fix it in the latest commit in https://git.m-labs.hk/M-Labs/nac3/commit/1c170f5c411ab305f6466748c3819c1b768c79b4. It seems ok now.
sb10q closed this issue 2021-09-22 15:17:19 +08:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#10
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?