[core] coregen/types: Implement StructFields for NDArray

Also rename some fields to better align with their naming in numpy.
[core] codegen/types: Implement NDArray in terms of i8*
2024-11-20 15:39:00 +08:00 · 2024-11-20 15:35:57 +08:00
1 changed files with 2 additions and 8 deletions
--- a/nac3core/src/codegen/values/ndarray.rs
+++ b/nac3core/src/codegen/values/ndarray.rs
@ -326,10 +326,7 @@ impl<'ctx> ArrayLikeIndexer<'ctx> for NDArrayDataProxy<'ctx, '_> {
                )
                .unwrap()
        };
-
-        // Current implementation is transparent - The returned pointer type is
-        // already cast into the expected type, allowing for immediately
-        // load/store.
+        // TODO: Current implementation is transparent
        ctx.builder
            .build_pointer_cast(
                ptr,
@ -360,10 +357,7 @@ impl<'ctx> ArrayLikeIndexer<'ctx> for NDArrayDataProxy<'ctx, '_> {
        );

        let ptr = unsafe { self.ptr_offset_unchecked(ctx, generator, idx, name) };
-
-        // Current implementation is transparent - The returned pointer type is
-        // already cast into the expected type, allowing for immediately
-        // load/store.
+        // TODO: Current implementation is transparent
        ctx.builder
            .build_pointer_cast(
                ptr,
Author	SHA1	Message	Date
David Mak	0c0c2ebc8b	[core] coregen/types: Implement StructFields for NDArray Also rename some fields to better align with their naming in numpy.	2024-11-20 15:39:00 +08:00
David Mak	5576087164	[core] codegen/types: Implement NDArray in terms of i8* Better aligns with the future implementation of ndstrides.	2024-11-20 15:35:57 +08:00