M-Labs/nac3
M-Labs/nac3
8
1
Fork 12
Code Issues 98 Pull Requests 19 Releases Wiki Activity

core: Do not cast floor/ceil result to int

Browse Source 
NumPy explicitly states that the return type of the floor/ceil is float.
This commit is contained in:
David Mak 2023-10-06 17:35:18 +08:00
parent 95810d4229
commit 068f0d9faf
1 changed files with 2 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
nac3core/src/toplevel/builtins.rs
View File

@ -762,15 +762,7 @@ pub fn get_builtins(primitives: &mut (PrimitiveStore, Unifier)) -> BuiltinInfo {
.try_as_basic_value() .try_as_basic_value()
.left() .left()
.unwrap(); .unwrap();
Ok(Some( Ok(val.into())
ctx.builder
.build_float_to_signed_int(
val.into_float_value(),
ctx.ctx.i32_type(),
"fptosi",
)
.into(),
))
}, },
)))), )))),
loc: None, loc: None,
@ -802,15 +794,7 @@ pub fn get_builtins(primitives: &mut (PrimitiveStore, Unifier)) -> BuiltinInfo {
.try_as_basic_value() .try_as_basic_value()
.left() .left()
.unwrap(); .unwrap();
Ok(Some( Ok(val.into())
ctx.builder
.build_float_to_signed_int(
val.into_float_value(),
ctx.ctx.i32_type(),
"fptosi",
)
.into(),
))
}, },
)))), )))),
loc: None, loc: None,