mattermost: remove free edition spam properly #53

fsagbuya · 2024-12-12T12:32:58+08:00

fsagbuya commented

2024-12-12 12:32:58 +08:00

Description

Use updated mattermost from nixpkgs that builds webapp from source.
Add a patch to properly remove the FREE EDITION banner from UI.

Note:
Currently, the postInstall reference is patched as the webapp is invoked using curly braces ({}). A PR is opened to resolve this: https://github.com/NixOS/nixpkgs/pull/373085.

Once that PR is merged in nixos-24.11, the webapp can be overridden directly.

Closes #51

### Description - Use [updated mattermost](https://github.com/NixOS/nixpkgs/commit/af48e73f2f2c5a0b97dbd38d5baec7e3402f2f14) from nixpkgs that builds `webapp` from source. - Add a patch to properly remove the `FREE EDITION` banner from UI. **Note:** Currently, the `postInstall` reference is patched as the `webapp` is [invoked using curly braces](https://github.com/NixOS/nixpkgs/blob/nixos-24.11/pkgs/by-name/ma/mattermost/package.nix#L127) (`{}`). A PR is opened to resolve this: https://github.com/NixOS/nixpkgs/pull/373085. Once that PR is merged in `nixos-24.11`, the `webapp` can be overridden directly. Closes #51

sb10q commented

2024-12-12 12:41:32 +08:00

fix-package-lock-json.patch is massive. What's going on with it?

``fix-package-lock-json.patch`` is massive. What's going on with it?

fsagbuya commented

2024-12-12 12:47:35 +08:00

fix-package-lock-json.patch is massive. What's going on with it?

Error log in initial build: https://gist.github.com/fsagbuya/aadbe79e3b791c5c82e5bb917e2ca63d

Seems like an npm known issue for outdated lock files. https://github.com/NixOS/nixpkgs/issues/253879

> ``fix-package-lock-json.patch`` is massive. What's going on with it? Error log in initial build: https://gist.github.com/fsagbuya/aadbe79e3b791c5c82e5bb917e2ca63d Seems like an `npm` known issue for outdated lock files. https://github.com/NixOS/nixpkgs/issues/253879

sb10q commented

2024-12-12 12:48:31 +08:00

Does it really need such a huge patch?
How to generate it?

Does it really need such a huge patch? How to generate it?

fsagbuya commented

2024-12-12 12:54:36 +08:00

How to generate it?

By removing current package-lock.json and node_modules (if existing), then reinstall dependencies using npm i

Does it really need such a huge patch?

From what I see, it injects required resolved and integrity fields in the json file to those dependencies that don't have it.

> How to generate it? By removing current `package-lock.json` and `node_modules` (if existing), then reinstall dependencies using `npm i` > Does it really need such a huge patch? From what I see, it injects required `resolved` and `integrity` fields in the json file to those dependencies that don't have it.

fsagbuya changed title from ~~mattermost: build web app from source and remove spam properly~~ to WIP: build mattermost web app from source and remove spam properly

2024-12-12 13:37:44 +08:00

fsagbuya force-pushed mattermost-webapp from 70f766efe0 to 59b57f7103

2025-01-13 13:30:22 +08:00

Compare

fsagbuya changed title from ~~WIP: build mattermost web app from source and remove spam properly~~ to mattermost: remove free edition spam properly

2025-01-13 13:31:55 +08:00

fsagbuya commented

2025-01-13 13:32:36 +08:00

See updated description.

fsagbuya force-pushed mattermost-webapp from 59b57f7103 to f2ee0f1dbd

2025-01-13 13:34:23 +08:00

Compare

sb10q merged commit e2c78a5064 into master

2025-01-15 10:00:21 +08:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/it-infra#53