M-Labs/it-infra
M-Labs/it-infra
8
0
Fork 6
Code Issues 11 Pull Requests 1 Releases Wiki Activity

WIP: build mattermost web app from source and remove spam properly #53

Draft
fsagbuya wants to merge 3 commits from fsagbuya/it-infra:mattermost-webapp into master
pull from: fsagbuya/it-infra:mattermost-webapp
merge into: M-Labs:master
Conversation 4 Commits 3 Files Changed 4 +23818
fsagbuya commented 2024-12-12 12:32:58 +08:00
Collaborator
Copy Link

Description

Build web app from source, remove the FREE EDITION spam, and recompile from Nix.

Can submit a PR upstream for 9da70bd392

Closes #51

### Description Build web app from source, remove the `FREE EDITION` spam, and recompile from Nix. Can submit a PR upstream for https://git.m-labs.hk/M-Labs/it-infra/commit/9da70bd392f27bab2682b1bd3a8cd040f736d469 Closes #51
fsagbuya added 3 commits 2024-12-12 12:32:58 +08:00
sb10q commented 2024-12-12 12:41:32 +08:00
Owner
Copy Link

fix-package-lock-json.patch is massive. What's going on with it?

``fix-package-lock-json.patch`` is massive. What's going on with it?
fsagbuya commented 2024-12-12 12:47:35 +08:00
Author
Collaborator
Copy Link

fix-package-lock-json.patch is massive. What's going on with it?

Error log in initial build: https://gist.github.com/fsagbuya/aadbe79e3b791c5c82e5bb917e2ca63d

Seems like an npm known issue for outdated lock files. https://github.com/NixOS/nixpkgs/issues/253879

> ``fix-package-lock-json.patch`` is massive. What's going on with it? Error log in initial build: https://gist.github.com/fsagbuya/aadbe79e3b791c5c82e5bb917e2ca63d Seems like an `npm` known issue for outdated lock files. https://github.com/NixOS/nixpkgs/issues/253879
sb10q commented 2024-12-12 12:48:31 +08:00
Owner
Copy Link

Does it really need such a huge patch?
How to generate it?

Does it really need such a huge patch? How to generate it?
fsagbuya commented 2024-12-12 12:54:36 +08:00
Author
Collaborator
Copy Link

How to generate it?

By removing current package-lock.json and node_modules (if existing), then reinstall dependencies using npm i

Does it really need such a huge patch?

From what I see, it injects required resolved and integrity fields in the json file to those dependencies that don't have it.

> How to generate it? By removing current `package-lock.json` and `node_modules` (if existing), then reinstall dependencies using `npm i` > Does it really need such a huge patch? From what I see, it injects required `resolved` and `integrity` fields in the json file to those dependencies that don't have it.
fsagbuya changed title from mattermost: build web app from source and remove spam properly to WIP: build mattermost web app from source and remove spam properly 2024-12-12 13:37:44 +08:00
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u mattermost-webapp:fsagbuya-mattermost-webapp
git checkout fsagbuya-mattermost-webapp
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/it-infra#53
No description provided.
Delete Branch "fsagbuya/it-infra:mattermost-webapp"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?