M-Labs/it-infra
M-Labs
/
it-infra
8
0
Fork 6
Code Issues 11 Pull Requests Releases Wiki Activity

hydra: broaden allowedUris to m-labs repos #21

Closed
mwojcik wants to merge 1 commits from mwojcik/it-infra:alloweduris_update into master
pull from: mwojcik/it-infra:alloweduris_update
merge into: M-Labs:master
Conversation 2 Commits 1 Files Changed 1 +1 -1
mwojcik commented 2022-02-07 11:10:16 +08:00
Owner
Copy Link

Not exactly sure if it will work but it's not a blind guess either:

https://github.com/NixOS/nix/blob/master/src/libexpr/eval.cc#L571 - mentions that the URIs are prefixes

https://github.com/NixOS/nix/issues/2002#issuecomment-375270656 - this mentions an extreme example of allowedUris being "http:// https://" to allow for absolutely everything

Not exactly sure if it will work but it's not a blind guess either: https://github.com/NixOS/nix/blob/master/src/libexpr/eval.cc#L571 - mentions that the URIs are prefixes https://github.com/NixOS/nix/issues/2002#issuecomment-375270656 - this mentions an extreme example of allowedUris being "http:// https://" to allow for absolutely everything
mwojcik added 1 commit 2022-02-07 11:10:16 +08:00
sb10q commented 2022-02-07 11:11:07 +08:00
Owner
Copy Link

Not exactly sure if it will work

The Nix issue mentions a repro that does not need Hydra.

> Not exactly sure if it will work The Nix issue mentions a repro that does not need Hydra.
sb10q reviewed 2022-02-07 11:11:45 +08:00
nixbld-etc-nixos/hydra-hack-allowed-uris.patch
@ -7,3 +7,3 @@
evalSettings.restrictEval = true;
+ evalSettings.allowedUris = {"https://github.com/m-labs/misoc.git"};
+ evalSettings.allowedUris = {"https://github.com/m-labs/ https://git.m-labs.hk/m-labs/"};
sb10q commented 2022-02-07 11:11:45 +08:00
Owner
Copy Link

Syntax seems wrong. I think this is an internal data structure and it should be parsed already.

Syntax seems wrong. I think this is an internal data structure and it should be parsed already.
sb10q commented 2022-02-07 14:33:18 +08:00
Owner
Copy Link

322d267caf

https://git.m-labs.hk/M-Labs/it-infra/commit/322d267caf84989d0d7e21b895db9bbece90eaea
sb10q closed this pull request 2022-02-07 14:33:19 +08:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/it-infra#21
No description provided.
Delete Branch "mwojcik/it-infra:alloweduris_update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?