gitea notification token syntax #14

New Issue

sb10q · 2021-01-27T11:56:38+08:00

sb10q commented

2021-01-27 11:56:38 +08:00

With the current code, the working syntax for the token is:

token ${(import /etc/nixos/secret/gitea_tokens.nix).artiq-zynq}

and not

authorization = token ${(import /etc/nixos/secret/gitea_tokens.nix).artiq-zynq}

The latter is consistent with the GitHub status plugin.

With the current code, the working syntax for the token is: ``` token ${(import /etc/nixos/secret/gitea_tokens.nix).artiq-zynq} ``` and not ``` authorization = token ${(import /etc/nixos/secret/gitea_tokens.nix).artiq-zynq} ``` The latter is consistent with the GitHub status plugin.

astro was assigned by sb10q

2021-01-27 11:57:10 +08:00

sb10q referenced this issue from a commit

2021-01-27 11:59:17 +08:00

nixbld: work around Gitea token syntax problem (#14)

astro commented

2021-01-27 22:59:04 +08:00

Keeping it authorization was my oversight in #13. I am sorry for delivering broken code.

In the GithubStatus plugin the authorization key's value is copied as-is into the HTTP header Authorization. The token prefix will not be split away.

For the new GiteaStatus plugin the value is appended to the URI in the query parameter ?token=. Therefore I argue that token doesn't change terminology in the context of Gitea. Of course the final decision is up to you.

Keeping it `authorization` was my oversight in #13. I am sorry for delivering broken code. In the **GithubStatus** plugin the `authorization` key's value is copied as-is into the HTTP header `Authorization`. The `token ` prefix will not be split away. For the new **GiteaStatus** plugin the value is appended to the URI in the query parameter `?token=`. Therefore I argue that `token` doesn't change terminology in the context of Gitea. Of course the final decision is up to you.

astro commented

2021-04-09 00:39:24 +08:00

Another GiteaStatus plugin got merged: https://github.com/NixOS/hydra/pull/904

Sign in to join this conversation.

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/it-infra#14