M-Labs/defenestrate
M-Labs
/
defenestrate
2
0
Fork 3
Code Issues 3 Pull Requests 2 Projects Releases Wiki Activity

Minor improvements and normalization towards Quartiq workflow #6

Open
eduardotenholder wants to merge 17 commits from eduardotenholder/defenestrate:quartiq into master
pull from: eduardotenholder/defenestrate:quartiq
merge into: M-Labs:master
Conversation 2 Commits 17 Files Changed 5 +49 -20
eduardotenholder commented 2024-10-14 17:16:09 +08:00
First-time contributor
Copy Link

All warnings throughout the build process have been eliminated.
End users are in charge of i18n now, according to their individual desires.
A seal-off script takes care of the final setup steps.
Use Btrfs in favor of Ext4 for snapshots and enhanced user support.

All warnings throughout the build process have been eliminated. End users are in charge of i18n now, according to their individual desires. A seal-off script takes care of the final setup steps. Use Btrfs in favor of Ext4 for snapshots and enhanced user support.
eduardotenholder added 14 commits 2024-10-14 17:16:09 +08:00
eduardotenholder requested review from sb10q 2024-10-14 17:16:48 +08:00
sb10q reviewed 2024-10-14 18:52:31 +08:00
sb10q reviewed 2024-10-14 18:56:08 +08:00
README Outdated
@ -1,10 +1,8 @@
* Enter BIOS, disable secure boot, enable UEFI PXE network boot
* sudo auto-install
* sudo reboot
sb10q commented 2024-10-14 18:56:08 +08:00
Owner
Copy Link

The issue with auto-reboot here is you need to monitor the installation and then select memtest86 after it has finished.
Either somehow set up the bootloader so it runs memtest86 on the first boot, or move memtest86 at the end (but user reboot is still necessary so it's not clear what has been added with auto-reboot, and also auto-reboot loses any messages printed by nixos-install), or revert this change.

The issue with auto-reboot here is you need to monitor the installation and then select memtest86 after it has finished. Either somehow set up the bootloader so it runs memtest86 on the first boot, or move memtest86 at the end (but user reboot is still necessary so it's not clear what has been added with auto-reboot, and also auto-reboot loses any messages printed by nixos-install), or revert this change.
sb10q reviewed 2024-10-14 18:56:54 +08:00
final/configuration.nix Outdated
@ -2,2 +2,3 @@
{
let
sealOff = pkgs.writeShellScriptBin "seal-off"
sb10q commented 2024-10-14 18:56:54 +08:00
Owner
Copy Link

This stays in the final environment and pollutes it.

This stays in the final environment and pollutes it.
sb10q reviewed 2024-10-14 18:58:27 +08:00
default.nix Outdated
@ -48,2 +51,3 @@
documentation.man.enable = false;
nix.settings.trusted-public-keys = ["nixbld.m-labs.hk-1:5aSRVA5b320xbNvu30tqxVPXpld73bhtOeH6uAjRyHc="];
nix.settings.substituters = ["https://nixbld.m-labs.hk?priority=10"];
nix.settings.substituters = ["https://nixbld.m-labs.hk"];
sb10q commented 2024-10-14 18:58:27 +08:00
Owner
Copy Link

The priority setting is there for a reason: most packages get downloaded from the LAN when we install here.
It's probably not what you want from Germany, so make it configurable (i.e. option in default.nix, which can be off by default, and which would be turned on when building the netboot image on nixbld).

The priority setting is there for a reason: most packages get downloaded from the LAN when we install here. It's probably not what you want from Germany, so make it configurable (i.e. option in default.nix, which can be off by default, and which would be turned on when building the netboot image on nixbld).
sb10q marked this conversation as resolved
eduardotenholder added 3 commits 2024-10-16 21:57:32 +08:00
eduardotenholder commented 2024-10-29 22:04:57 +08:00
Author
First-time contributor
Copy Link

@sb10q ?

@sb10q ?
sb10q reviewed 2024-10-30 13:40:28 +08:00
default.nix
@ -34,3 +34,3 @@
parted /dev/nvme0n1 -- mkpart ESP fat32 1MiB 512MiB
parted /dev/nvme0n1 -- set 2 esp on
mkfs.ext4 -L nixos /dev/nvme0n1p1
mkfs.btrfs -f -L nixos /dev/nvme0n1p1
sb10q commented 2024-10-30 13:40:28 +08:00
Owner
Copy Link

According to Phoronix benchmarks, btrfs is slower than ext4 and I think most desktop users won't need the advanced btrfs features. Why do you want it?

If this is controversial we can also make it configurable at netboot image build time, just like the nixbld.m-labs.hk substituter priority.

According to Phoronix benchmarks, btrfs is slower than ext4 and I think most desktop users won't need the advanced btrfs features. Why do you want it? If this is controversial we can also make it configurable at netboot image build time, just like the nixbld.m-labs.hk substituter priority.
sb10q commented 2024-10-30 14:48:44 +08:00
Owner
Copy Link

Edited and merged non-controversial changes manually.

Edited and merged non-controversial changes manually.
This pull request has changes conflicting with the target branch.
  • README
  • default.nix
  • final/configuration.nix
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b eduardotenholder-quartiq master
git pull quartiq

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff eduardotenholder-quartiq
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
sb10q
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/defenestrate#6
No description provided.
Delete Branch "eduardotenholder/defenestrate:quartiq"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?