Merge pull request #276 from hug-dev/armv8m-support

Fix compilation errors for Armv8-M Baseline and Mainline with FPU
This commit is contained in:
Alex Crichton 2019-03-14 09:15:10 -05:00 committed by GitHub
commit 4078c99f9b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 31 additions and 81 deletions

View File

@ -50,10 +50,11 @@ fn main() {
println!("cargo:rustc-cfg=thumb") println!("cargo:rustc-cfg=thumb")
} }
// compiler-rt `cfg`s away some intrinsics for thumbv6m because that target doesn't have full // compiler-rt `cfg`s away some intrinsics for thumbv6m and thumbv8m.base because
// THUMBv2 support. We have to cfg our code accordingly. // these targets do not have full Thumb-2 support but only original Thumb-1.
if llvm_target[0] == "thumbv6m" { // We have to cfg our code accordingly.
println!("cargo:rustc-cfg=thumbv6m") if llvm_target[0] == "thumbv6m" || llvm_target[0] == "thumbv8m.base" {
println!("cargo:rustc-cfg=thumb_1")
} }
// Only emit the ARM Linux atomic emulation on pre-ARMv6 architectures. // Only emit the ARM Linux atomic emulation on pre-ARMv6 architectures.
@ -360,24 +361,36 @@ mod c {
} }
if llvm_target.last().unwrap().ends_with("eabihf") { if llvm_target.last().unwrap().ends_with("eabihf") {
if !llvm_target[0].starts_with("thumbv7em") { if !llvm_target[0].starts_with("thumbv7em") &&
!llvm_target[0].starts_with("thumbv8m.main") {
// The FPU option chosen for these architectures in cc-rs, ie:
// -mfpu=fpv4-sp-d16 for thumbv7em
// -mfpu=fpv5-sp-d16 for thumbv8m.main
// do not support double precision floating points conversions so the files
// that include such instructions are not included for these targets.
sources.extend( sources.extend(
&[ &[
"arm/fixdfsivfp.S", "arm/fixdfsivfp.S",
"arm/fixsfsivfp.S",
"arm/fixunsdfsivfp.S", "arm/fixunsdfsivfp.S",
"arm/fixunssfsivfp.S",
"arm/floatsidfvfp.S", "arm/floatsidfvfp.S",
"arm/floatsisfvfp.S",
"arm/floatunssidfvfp.S", "arm/floatunssidfvfp.S",
"arm/floatunssisfvfp.S",
"arm/restore_vfp_d8_d15_regs.S",
"arm/save_vfp_d8_d15_regs.S",
], ],
); );
} }
sources.extend(&["arm/negdf2vfp.S", "arm/negsf2vfp.S"]); sources.extend(
&[
"arm/fixsfsivfp.S",
"arm/fixunssfsivfp.S",
"arm/floatsisfvfp.S",
"arm/floatunssisfvfp.S",
"arm/floatunssisfvfp.S",
"arm/restore_vfp_d8_d15_regs.S",
"arm/save_vfp_d8_d15_regs.S",
"arm/negdf2vfp.S",
"arm/negsf2vfp.S",
]
);
} }
@ -408,7 +421,7 @@ mod c {
} }
// Remove the assembly implementations that won't compile for the target // Remove the assembly implementations that won't compile for the target
if llvm_target[0] == "thumbv6m" { if llvm_target[0] == "thumbv6m" || llvm_target[0] == "thumbv8m.base" {
sources.remove( sources.remove(
&[ &[
"clzdi2", "clzdi2",

View File

@ -19,9 +19,6 @@ extern crate panic_handler;
#[link(name = "c")] #[link(name = "c")]
extern {} extern {}
// NOTE cfg(not(thumbv6m)) means that the operation is not supported on ARMv6-M at all. Not even
// compiler-rt provides a C/assembly implementation.
// Every function in this module maps will be lowered to an intrinsic by LLVM, if the platform // Every function in this module maps will be lowered to an intrinsic by LLVM, if the platform
// doesn't have native support for the operation used in the function. ARM has a naming convention // doesn't have native support for the operation used in the function. ARM has a naming convention
// convention for its intrinsics that's different from other architectures; that's why some function // convention for its intrinsics that's different from other architectures; that's why some function
@ -39,70 +36,40 @@ mod intrinsics {
} }
// fixdfdi // fixdfdi
#[cfg(not(thumbv6m))]
pub fn aeabi_d2l(x: f64) -> i64 { pub fn aeabi_d2l(x: f64) -> i64 {
x as i64 x as i64
} }
#[cfg(thumbv6m)]
pub fn aeabi_d2l(_: f64) -> i64 {
0
}
// fixunsdfsi // fixunsdfsi
pub fn aeabi_d2uiz(x: f64) -> u32 { pub fn aeabi_d2uiz(x: f64) -> u32 {
x as u32 x as u32
} }
// fixunsdfdi // fixunsdfdi
#[cfg(not(thumbv6m))]
pub fn aeabi_d2ulz(x: f64) -> u64 { pub fn aeabi_d2ulz(x: f64) -> u64 {
x as u64 x as u64
} }
#[cfg(thumbv6m)]
pub fn aeabi_d2ulz(_: f64) -> u64 {
0
}
// adddf3 // adddf3
pub fn aeabi_dadd(a: f64, b: f64) -> f64 { pub fn aeabi_dadd(a: f64, b: f64) -> f64 {
a + b a + b
} }
// eqdf2 // eqdf2
#[cfg(not(thumbv6m))]
pub fn aeabi_dcmpeq(a: f64, b: f64) -> bool { pub fn aeabi_dcmpeq(a: f64, b: f64) -> bool {
a == b a == b
} }
#[cfg(thumbv6m)]
pub fn aeabi_dcmpeq(_: f64, _: f64) -> bool {
true
}
// gtdf2 // gtdf2
#[cfg(not(thumbv6m))]
pub fn aeabi_dcmpgt(a: f64, b: f64) -> bool { pub fn aeabi_dcmpgt(a: f64, b: f64) -> bool {
a > b a > b
} }
#[cfg(thumbv6m)]
pub fn aeabi_dcmpgt(_: f64, _: f64) -> bool {
true
}
// ltdf2 // ltdf2
#[cfg(not(thumbv6m))]
pub fn aeabi_dcmplt(a: f64, b: f64) -> bool { pub fn aeabi_dcmplt(a: f64, b: f64) -> bool {
a < b a < b
} }
#[cfg(thumbv6m)]
pub fn aeabi_dcmplt(_: f64, _: f64) -> bool {
true
}
// divdf3 // divdf3
pub fn aeabi_ddiv(a: f64, b: f64) -> f64 { pub fn aeabi_ddiv(a: f64, b: f64) -> f64 {
a / b a / b
@ -129,70 +96,40 @@ mod intrinsics {
} }
// fixsfdi // fixsfdi
#[cfg(not(thumbv6m))]
pub fn aeabi_f2lz(x: f32) -> i64 { pub fn aeabi_f2lz(x: f32) -> i64 {
x as i64 x as i64
} }
#[cfg(thumbv6m)]
pub fn aeabi_f2lz(_: f32) -> i64 {
0
}
// fixunssfsi // fixunssfsi
pub fn aeabi_f2uiz(x: f32) -> u32 { pub fn aeabi_f2uiz(x: f32) -> u32 {
x as u32 x as u32
} }
// fixunssfdi // fixunssfdi
#[cfg(not(thumbv6m))]
pub fn aeabi_f2ulz(x: f32) -> u64 { pub fn aeabi_f2ulz(x: f32) -> u64 {
x as u64 x as u64
} }
#[cfg(thumbv6m)]
pub fn aeabi_f2ulz(_: f32) -> u64 {
0
}
// addsf3 // addsf3
pub fn aeabi_fadd(a: f32, b: f32) -> f32 { pub fn aeabi_fadd(a: f32, b: f32) -> f32 {
a + b a + b
} }
// eqsf2 // eqsf2
#[cfg(not(thumbv6m))]
pub fn aeabi_fcmpeq(a: f32, b: f32) -> bool { pub fn aeabi_fcmpeq(a: f32, b: f32) -> bool {
a == b a == b
} }
#[cfg(thumbv6m)]
pub fn aeabi_fcmpeq(_: f32, _: f32) -> bool {
true
}
// gtsf2 // gtsf2
#[cfg(not(thumbv6m))]
pub fn aeabi_fcmpgt(a: f32, b: f32) -> bool { pub fn aeabi_fcmpgt(a: f32, b: f32) -> bool {
a > b a > b
} }
#[cfg(thumbv6m)]
pub fn aeabi_fcmpgt(_: f32, _: f32) -> bool {
true
}
// ltsf2 // ltsf2
#[cfg(not(thumbv6m))]
pub fn aeabi_fcmplt(a: f32, b: f32) -> bool { pub fn aeabi_fcmplt(a: f32, b: f32) -> bool {
a < b a < b
} }
#[cfg(thumbv6m)]
pub fn aeabi_fcmplt(_: f32, _: f32) -> bool {
true
}
// divsf3 // divsf3
pub fn aeabi_fdiv(a: f32, b: f32) -> f32 { pub fn aeabi_fdiv(a: f32, b: f32) -> f32 {
a / b a / b

View File

@ -74,8 +74,8 @@ intrinsics! {
#[use_c_shim_if(all(target_arch = "arm", #[use_c_shim_if(all(target_arch = "arm",
not(target_os = "ios"), not(target_os = "ios"),
not(target_env = "msvc")), not(target_env = "msvc"),
not(thumbv6m))] not(thumb_1)))]
pub extern "C" fn __modsi3(a: i32, b: i32) -> i32 { pub extern "C" fn __modsi3(a: i32, b: i32) -> i32 {
a.mod_(b) a.mod_(b)
} }
@ -91,7 +91,7 @@ intrinsics! {
} }
#[use_c_shim_if(all(target_arch = "arm", not(target_env = "msvc"), #[use_c_shim_if(all(target_arch = "arm", not(target_env = "msvc"),
not(target_os = "ios"), not(thumbv6m)))] not(target_os = "ios"), not(thumb_1)))]
pub extern "C" fn __divmodsi4(a: i32, b: i32, rem: &mut i32) -> i32 { pub extern "C" fn __divmodsi4(a: i32, b: i32, rem: &mut i32) -> i32 {
a.divmod(b, rem, |a, b| __divsi3(a, b)) a.divmod(b, rem, |a, b| __divsi3(a, b))
} }

View File

@ -212,7 +212,7 @@ intrinsics! {
#[use_c_shim_if(all(target_arch = "arm", #[use_c_shim_if(all(target_arch = "arm",
not(target_os = "ios"), not(target_os = "ios"),
not(target_env = "msvc"), not(target_env = "msvc"),
not(thumbv6m)))] not(thumb_1)))]
/// Returns `n % d` /// Returns `n % d`
pub extern "C" fn __umodsi3(n: u32, d: u32) -> u32 { pub extern "C" fn __umodsi3(n: u32, d: u32) -> u32 {
let q = __udivsi3(n, d); let q = __udivsi3(n, d);
@ -222,7 +222,7 @@ intrinsics! {
#[use_c_shim_if(all(target_arch = "arm", #[use_c_shim_if(all(target_arch = "arm",
not(target_os = "ios"), not(target_os = "ios"),
not(target_env = "msvc"), not(target_env = "msvc"),
not(thumbv6m)))] not(thumb_1)))]
/// Returns `n / d` and sets `*rem = n % d` /// Returns `n / d` and sets `*rem = n % d`
pub extern "C" fn __udivmodsi4(n: u32, d: u32, rem: Option<&mut u32>) -> u32 { pub extern "C" fn __udivmodsi4(n: u32, d: u32, rem: Option<&mut u32>) -> u32 {
let q = __udivsi3(n, d); let q = __udivsi3(n, d);