AD9910 get/set default behavior out of sync #1446

New Issue

bradbqc · 2026-01-18T19:03:07+08:00

bradbqc commented

2026-01-18 19:03:07 +08:00

Migrated from GitHub: #1809

Bug Report

One-Line Summary

As of #1584, AD9910 get/get_mu and set/set_mu behavior is not aligned.

Issue Details

At a minimum, the default profile used for the get methods should be updated to reflect set. But there are also some significant changes to set in the presence of the (new) ram_destination parameter that should perhaps also be reflected in get.

For simplicity, and to avoid this problem in the future (at least for default arguments), it might make sense to have some module/class variables for default profiles, e.g.:

_DEFAULT_PROFILE = 7
_DEFAULT_PROFILE_RAM = 0

> **Migrated from GitHub:** [#1809](https://github.com/m-labs/artiq/issues/1809) ---  # Bug Report  ## One-Line Summary As of #1584, AD9910 `get`/`get_mu` and `set`/`set_mu` behavior is not aligned. ## Issue Details At a minimum, the default profile used for the `get` methods should be updated to reflect `set`. But there are also some significant changes to `set` in the presence of the (new) `ram_destination` parameter that should perhaps also be reflected in `get`. For simplicity, and to avoid this problem in the future (at least for default arguments), it might make sense to have some module/class variables for default profiles, e.g.: ``` _DEFAULT_PROFILE = 7 _DEFAULT_PROFILE_RAM = 0 ```

sb10q closed this issue

2026-01-18 19:03:07 +08:00

bradbqc commented

2026-01-18 19:03:07 +08:00

@lriesebos

sb10q commented

2026-01-18 19:03:07 +08:00

@occheung

dpn commented

2026-01-18 19:03:07 +08:00

@pmldrmota

occheung commented

2026-01-18 19:03:07 +08:00

#1818 made the default behavior consistent.

But there are also some significant changes to set in the presence of the (new) ram_destination parameter that should perhaps also be reflected in get.

Please open another issue if you want this change.

#1818 made the default behavior consistent. > But there are also some significant changes to set in the presence of the (new) ram_destination parameter that should perhaps also be reflected in get. Please open another issue if you want this change.

Sign in to join this conversation.

4 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq#1446