From 06e626024bb76359c45aa679d70c9b05eb898f20 Mon Sep 17 00:00:00 2001 From: Sebastien Bourdeauducq Date: Wed, 30 Mar 2016 11:39:36 +0800 Subject: [PATCH] gui: setParent(None) before deleteLater() to remove dock appears unnecessary and causes memory corruption on Windows. Closes #362 --- artiq/gui/applets.py | 1 - artiq/gui/log.py | 1 - 2 files changed, 2 deletions(-) diff --git a/artiq/gui/applets.py b/artiq/gui/applets.py index 78ff02d1f..09a1fe56c 100644 --- a/artiq/gui/applets.py +++ b/artiq/gui/applets.py @@ -167,7 +167,6 @@ class _AppletDock(QDockWidgetCloseDetect): self.starting_stopping = False if delete_self: - self.setParent(None) self.deleteLater() async def restart(self): diff --git a/artiq/gui/log.py b/artiq/gui/log.py index 0f1677e5f..56215f10a 100644 --- a/artiq/gui/log.py +++ b/artiq/gui/log.py @@ -356,7 +356,6 @@ class LogDockManager: def on_dock_closed(self, name): dock = self.docks[name] - dock.setParent(None) dock.deleteLater() del self.docks[name] self.update_closable()